Skip to content

Update cookie secret comment in migration guide #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update cookie secret comment in migration guide #709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/migrate/from-hono.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,7 +1062,7 @@ import { Elysia } from 'elysia'

const app = new Elysia({
cookie: {
secret: 'secret'
secret: 'secret' // Need to set to have cookies signed
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix indentation: replace hard tab with spaces.

The static analysis tool flagged a hard tab character at the beginning of this line. Markdown files should use spaces for indentation to maintain consistency.

Replace the hard tab with spaces to align indentation with the rest of the code block.

- [TAB]secret: 'secret' // Need to set to have cookies signed
+ [SPACES]secret: 'secret' // Need to set to have cookies signed

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

1065-1065: Hard tabs
Column: 1

(MD010, no-hard-tabs)

🤖 Prompt for AI Agents 
In docs/migrate/from-hono.md around line 1065, the line beginning with a hard
tab ("		secret: 'secret' // Need to set to have cookies signed") uses a tab for
indentation; replace the leading tab character with the appropriate number of
spaces to match the surrounding code block indentation (use spaces consistently,
e.g., two or four spaces as used elsewhere in that block) so the file no longer
contains hard tabs.

}
})
.get('/', ({ cookie: { name } }) => {
Expand Down