Skip to content

Commit 4cbb865

Browse files
author
Aaron Chambers
committed
Merge pull request #19 from dannyfallon/df/fix-keep-gzip-return-context
Fix the plugin return object for keep-enabled gzipping
2 parents e7969c4 + 6a8f099 commit 4cbb865

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@ module.exports = {
5959
if (keep) {
6060
self.log('keep is enabled, added gzipped files to `context.distFiles`', { verbose: true });
6161
return {
62-
distFiles: gzippedFiles,
62+
distFiles: [].concat(gzippedFiles), // needs to be a copy
6363
gzippedFiles: gzippedFiles
64-
}
64+
};
6565
}
6666
return { gzippedFiles: gzippedFiles };
6767
})

tests/unit/index-nodetest.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,16 @@ describe('gzip plugin', function() {
184184
done(reason);
185185
});
186186
});
187+
188+
it('does not use the same object for gzippedFiles and distFiles', function(done) {
189+
return assert.isFulfilled(plugin.willUpload(context))
190+
.then(function(result) {
191+
assert.notStrictEqual(result.distFiles, result.gzippedFiles);
192+
done();
193+
}).catch(function(reason){
194+
done(reason);
195+
});
196+
});
187197
});
188198
});
189199
});

0 commit comments

Comments
 (0)