Avoid throwing of plain JS strings. NFC

Replaced with `assert`, `abort` or `throw new Error` accordingly.  We
almost never want to be throwing plain values because we don't end up
with a stack trace in that case.

Author: sbc100

src/cpuprofiler.js

@@ -655,7 +655,7 @@ var emscriptenCpuProfiler = {
       case 9: glCtx[f] = (a1, a2, a3, a4, a5, a6, a7, a8, a9) => { this.enterSection(section); var ret =  glCtx[realf](a1, a2, a3, a4, a5, a6, a7, a8, a9); this.endSection(section); return ret; }; break;
       case 10: glCtx[f] = (a1, a2, a3, a4, a5, a6, a7, a8, a9, a10) => { this.enterSection(section); var ret =  glCtx[realf](a1, a2, a3, a4, a5, a6, a7, a8, a9, a10); this.endSection(section); return ret; }; break;
       case 11: glCtx[f] = (a1, a2, a3, a4, a5, a6, a7, a8, a9, a10, a11) => { this.enterSection(section); var ret =  glCtx[realf](a1, a2, a3, a4, a5, a6, a7, a8, a9, a10, a11); this.endSection(section); return ret; }; break;
-      default: throw 'hookWebGL failed! Unexpected length ' + glCtx[realf].length;
+      default: throw new Error('hookWebGL failed! Unexpected length ' + glCtx[realf].length);
     }
   },
 

src/jsifier.mjs

@@ -316,6 +316,12 @@ function handleI64Signatures(symbol, snippet, sig, i53abi) {
       // For functions that where we need to mutate the return value, we
       // also need to wrap the body in an inner function.
       if (oneliner) {
+        // Special case for abort(), this a noreturn function and but closure
+        // compiler doesn't have a way to express that, so it complains if we
+        // do `BigInt(abort(..))`.
+        if (body.startsWith('abort(')) {
+          return snippet;
+        }
         if (argConversions) {
           return `${async_}(${args}) => {
 ${argConversions}

src/lib/libaddfunction.js

@@ -159,7 +159,7 @@ addToLibrary({
       if (!(err instanceof RangeError)) {
         throw err;
       }
-      throw 'Unable to grow wasm table. Set ALLOW_TABLE_GROWTH.';
+      abort('Unable to grow wasm table. Set ALLOW_TABLE_GROWTH.');
     }
 #endif
   },

src/lib/libasync.js

@@ -84,7 +84,7 @@ addToLibrary({
                   !isAsyncifyImport &&
                   !changedToDisabled &&
                   !ignoredInvoke) {
-                throw new Error(`import ${x} was not in ASYNCIFY_IMPORTS, but changed the state`);
+                abort(`import ${x} was not in ASYNCIFY_IMPORTS, but changed the state`);
               }
             }
           };
@@ -664,19 +664,19 @@ addToLibrary({
   },
 #else // ASYNCIFY
   emscripten_sleep: () => {
-    throw 'Please compile your program with async support in order to use asynchronous operations like emscripten_sleep';
+    abort('Please compile your program with async support in order to use asynchronous operations like emscripten_sleep');
   },
   emscripten_wget: (url, file) => {
-    throw 'Please compile your program with async support in order to use asynchronous operations like emscripten_wget';
+    abort('Please compile your program with async support in order to use asynchronous operations like emscripten_wget');
   },
   emscripten_wget_data: (url, pbuffer, pnum, perror) => {
-    throw 'Please compile your program with async support in order to use asynchronous operations like emscripten_wget_data';
+    abort('Please compile your program with async support in order to use asynchronous operations like emscripten_wget_data');
   },
   emscripten_scan_registers: (func) => {
-    throw 'Please compile your program with async support in order to use asynchronous operations like emscripten_scan_registers';
+    abort('Please compile your program with async support in order to use asynchronous operations like emscripten_scan_registers');
   },
   emscripten_fiber_swap: (oldFiber, newFiber) => {
-    throw 'Please compile your program with async support in order to use asynchronous operations like emscripten_fiber_swap';
+    abort('Please compile your program with async support in order to use asynchronous operations like emscripten_fiber_swap');
   },
 #endif // ASYNCIFY
 });

src/lib/libbrowser.js

@@ -374,11 +374,11 @@ var LibraryBrowser = {
               delta *= 80;
               break;
             default:
-              throw 'unrecognized mouse wheel delta mode: ' + event.deltaMode;
+              abort('unrecognized mouse wheel delta mode: ' + event.deltaMode);
           }
           break;
         default:
-          throw 'unrecognized mouse wheel event: ' + event.type;
+          abort('unrecognized mouse wheel event: ' + event.type);
       }
       return delta;
     },
@@ -804,7 +804,7 @@ var LibraryBrowser = {
 #if BUILD_AS_WORKER
   emscripten_worker_respond_provisionally__proxy: 'sync',
   emscripten_worker_respond_provisionally: (data, size) => {
-    if (workerResponded) throw 'already responded with final response!';
+    if (workerResponded) abort('already responded with final response!');
     var transferObject = {
       'callbackId': workerCallbackId,
       'finalResponse': false,
@@ -819,7 +819,7 @@ var LibraryBrowser = {
 
   emscripten_worker_respond__proxy: 'sync',
   emscripten_worker_respond: (data, size) => {
-    if (workerResponded) throw 'already responded with final response!';
+    if (workerResponded) abort('already responded with final response!');
     workerResponded = true;
     var transferObject = {
       'callbackId': workerCallbackId,

src/lib/libc_preprocessor.js

@@ -204,7 +204,7 @@ addToLibrary({
           }
           // else a number:
 #if ASSERTIONS
-          if (tokens[i] == ')') throw 'Parsing failure, mismatched parentheses in parsing!' + tokens.toString();
+          assert(tokens[i] !== ')', 'Parsing failure, mismatched parentheses in parsing!' + tokens.toString());
           assert(operatorAndPriority == -1);
 #endif
           var num = Number(tokens[i]);

src/lib/libcore.js

@@ -1426,12 +1426,10 @@ addToLibrary({
 
   // We never free the return values of this function so we need to allocate
   // using builtin_malloc to avoid LSan reporting these as leaks.
-  emscripten_get_compiler_setting__noleakcheck: true,
 #if RETAIN_COMPILER_SETTINGS
+  emscripten_get_compiler_setting__noleakcheck: true,
   emscripten_get_compiler_setting__deps: ['$stringToNewUTF8'],
-#endif
   emscripten_get_compiler_setting: (name) => {
-#if RETAIN_COMPILER_SETTINGS
     name = UTF8ToString(name);
 
     var ret = getCompilerSetting(name);
@@ -1441,10 +1439,10 @@ addToLibrary({
     var fullret = cache[name];
     if (fullret) return fullret;
     return cache[name] = stringToNewUTF8(ret);
+  },
 #else
-    throw 'You must build with -sRETAIN_COMPILER_SETTINGS for getCompilerSetting or emscripten_get_compiler_setting to work';
+  emscripten_get_compiler_setting: (name) => abort('You must build with -sRETAIN_COMPILER_SETTINGS for getCompilerSetting or emscripten_get_compiler_setting to work'),
 #endif
-  },
 
   emscripten_has_asyncify: () => {{{ ASYNCIFY }}},
 

src/lib/libfs.js

@@ -1351,7 +1351,7 @@ FS.staticInit();`;
       opts.flags = opts.flags || {{{ cDefs.O_RDONLY }}};
       opts.encoding = opts.encoding || 'binary';
       if (opts.encoding !== 'utf8' && opts.encoding !== 'binary') {
-        throw new Error(`Invalid encoding type "${opts.encoding}"`);
+        abort(`Invalid encoding type "${opts.encoding}"`);
       }
       var stream = FS.open(path, opts.flags);
       var stat = FS.stat(path);
@@ -1373,7 +1373,7 @@ FS.staticInit();`;
       if (ArrayBuffer.isView(data)) {
         FS.write(stream, data, 0, data.byteLength, undefined, opts.canOwn);
       } else {
-        throw new Error('Unsupported data type');
+        abort('Unsupported data type');
       }
       FS.close(stream);
     },
@@ -1706,7 +1706,7 @@ FS.staticInit();`;
       dbg(`forceLoadFile: ${obj.url}`)
  #endif
       if (typeof XMLHttpRequest != 'undefined') {
-        throw new Error("Lazy loading should have been performed (contents set) in createLazyFile, but it was not. Lazy loading only works in web workers. Use --embed-file or --preload-file in emcc on the main thread.");
+        abort("Lazy loading should have been performed (contents set) in createLazyFile, but it was not. Lazy loading only works in web workers. Use --embed-file or --preload-file in emcc on the main thread.");
       } else { // Command-line.
         try {
           obj.contents = readBinary(obj.url);
@@ -1749,7 +1749,7 @@ FS.staticInit();`;
           var xhr = new XMLHttpRequest();
           xhr.open('HEAD', url, false);
           xhr.send(null);
-          if (!(xhr.status >= 200 && xhr.status < 300 || xhr.status === 304)) throw new Error("Couldn't load " + url + ". Status: " + xhr.status);
+          if (!(xhr.status >= 200 && xhr.status < 300 || xhr.status === 304)) abort("Couldn't load " + url + ". Status: " + xhr.status);
           var datalength = Number(xhr.getResponseHeader("Content-length"));
           var header;
           var hasByteServing = (header = xhr.getResponseHeader("Accept-Ranges")) && header === "bytes";
@@ -1765,8 +1765,8 @@ FS.staticInit();`;
 
           // Function to get a range from the remote URL.
           var doXHR = (from, to) => {
-            if (from > to) throw new Error("invalid range (" + from + ", " + to + ") or no bytes requested!");
-            if (to > datalength-1) throw new Error("only " + datalength + " bytes available! programmer error!");
+            if (from > to) abort("invalid range (" + from + ", " + to + ") or no bytes requested!");
+            if (to > datalength-1) abort("only " + datalength + " bytes available! programmer error!");
 
             // TODO: Use mozResponseArrayBuffer, responseStream, etc. if available.
             var xhr = new XMLHttpRequest();
@@ -1780,7 +1780,7 @@ FS.staticInit();`;
             }
 
             xhr.send(null);
-            if (!(xhr.status >= 200 && xhr.status < 300 || xhr.status === 304)) throw new Error("Couldn't load " + url + ". Status: " + xhr.status);
+            if (!(xhr.status >= 200 && xhr.status < 300 || xhr.status === 304)) abort("Couldn't load " + url + ". Status: " + xhr.status);
             if (xhr.response !== undefined) {
               return new Uint8Array(/** @type{Array<number>} */(xhr.response || []));
             }
@@ -1794,7 +1794,7 @@ FS.staticInit();`;
             if (typeof lazyArray.chunks[chunkNum] == 'undefined') {
               lazyArray.chunks[chunkNum] = doXHR(start, end);
             }
-            if (typeof lazyArray.chunks[chunkNum] == 'undefined') throw new Error('doXHR failed!');
+            if (typeof lazyArray.chunks[chunkNum] == 'undefined') abort('doXHR failed!');
             return lazyArray.chunks[chunkNum];
           });
 
@@ -1825,7 +1825,7 @@ FS.staticInit();`;
       }
 
       if (typeof XMLHttpRequest != 'undefined') {
-        if (!ENVIRONMENT_IS_WORKER) throw 'Cannot do synchronous binary XHRs outside webworkers in modern browsers. Use --embed-file or --preload-file in emcc';
+        if (!ENVIRONMENT_IS_WORKER) abort('Cannot do synchronous binary XHRs outside webworkers in modern browsers. Use --embed-file or --preload-file in emcc');
         var lazyArray = new LazyUint8Array();
         var properties = { isDevice: false, contents: lazyArray };
       } else {

src/lib/libglemu.js

@@ -592,7 +592,7 @@ var LibraryGLEmulation = {
           dbg(`Info: ${JSON.stringify(GL.shaderInfos[shader])}`);
           dbg(`Original source: ${GL.shaderOriginalSources[shader]}`);
           dbg(`Source: ${GL.shaderSources[shader]}`);
-          throw 'Shader compilation halt';
+          abort('Shader compilation halt');
         }
 #endif
       };
@@ -3062,7 +3062,7 @@ var LibraryGLEmulation = {
           emulatedElementArrayBuffer = true;
         }
       } else if (GLImmediate.mode > 6) { // above GL_TRIANGLE_FAN are the non-GL ES modes
-        if (GLImmediate.mode != 7) throw 'unsupported immediate mode ' + GLImmediate.mode; // GL_QUADS
+        if (GLImmediate.mode != 7) abort('unsupported immediate mode ' + GLImmediate.mode); // GL_QUADS
         // GLImmediate.firstVertex is the first vertex we want. Quad indexes are
         // in the pattern 0 1 2, 0 2 3, 4 5 6, 4 6 7, so we need to look at
         // index firstVertex * 1.5 to see it.  Then since indexes are 2 bytes
@@ -3218,7 +3218,7 @@ var LibraryGLEmulation = {
   glTexCoord2fv: (v) =>
     _glTexCoord2i({{{ makeGetValue('v', '0', 'float') }}}, {{{ makeGetValue('v', '4', 'float') }}}),
 
-  glTexCoord4f: () => { throw 'glTexCoord4f: TODO' },
+  glTexCoord4f: () => { abort('glTexCoord4f: TODO') },
 
   glColor4f: (r, g, b, a) => {
     r = Math.max(Math.min(r, 1), 0);
@@ -3750,9 +3750,9 @@ var LibraryGLEmulation = {
   },
   glRotatef: 'glRotated',
 
-  glDrawBuffer: () => { throw 'glDrawBuffer: TODO' },
+  glDrawBuffer: () => { abort('glDrawBuffer: TODO') },
 #if MAX_WEBGL_VERSION < 2
-  glReadBuffer: () => { throw 'glReadBuffer: TODO' },
+  glReadBuffer: () => { abort('glReadBuffer: TODO') },
 #endif
 
   glClipPlane: (pname, param) => {
@@ -3800,7 +3800,7 @@ var LibraryGLEmulation = {
         // multiply position with current modelviewmatrix
         GLImmediate.matrixLib.mat4.multiplyVec4(GLImmediate.matrix[0], GLEmulation.lightPosition[lightId]);
       } else {
-        throw 'glLightfv: TODO: ' + pname;
+        abort('glLightfv: TODO: ' + pname);
       }
     }
   },
@@ -3809,7 +3809,7 @@ var LibraryGLEmulation = {
     if (pname == 0x0B52) { // GL_LIGHT_MODEL_TWO_SIDE
       GLEmulation.lightModelTwoSide = (param != 0) ? true : false;
     } else {
-      throw 'glLightModelf: TODO: ' + pname;
+      abort('glLightModelf: TODO: ' + pname);
     }
   },
 
@@ -3820,12 +3820,12 @@ var LibraryGLEmulation = {
       GLEmulation.lightModelAmbient[2] = {{{ makeGetValue('param', '8', 'float') }}};
       GLEmulation.lightModelAmbient[3] = {{{ makeGetValue('param', '12', 'float') }}};
     } else {
-      throw 'glLightModelfv: TODO: ' + pname;
+      abort('glLightModelfv: TODO: ' + pname);
     }
   },
 
   glMaterialfv: (face, pname, param) => {
-    if ((face != 0x0404) && (face != 0x0408)) { throw 'glMaterialfv: TODO' + face; } // only GL_FRONT and GL_FRONT_AND_BACK supported
+    if ((face != 0x0404) && (face != 0x0408)) { abort('glMaterialfv: TODO' + face); } // only GL_FRONT and GL_FRONT_AND_BACK supported
 
     if (pname == 0x1200) { // GL_AMBIENT
       GLEmulation.materialAmbient[0] = {{{ makeGetValue('param', '0', 'float') }}};
@@ -3845,22 +3845,22 @@ var LibraryGLEmulation = {
     } else if (pname == 0x1601) { // GL_SHININESS
       GLEmulation.materialShininess[0] = {{{ makeGetValue('param', '0', 'float') }}};
     } else {
-      throw 'glMaterialfv: TODO: ' + pname;
+      abort('glMaterialfv: TODO: ' + pname);
     }
   },
 
-  glTexGeni: (coord, pname, param) => { throw 'glTexGeni: TODO' },
-  glTexGenfv: (coord, pname, param) => { throw 'glTexGenfv: TODO' },
+  glTexGeni: (coord, pname, param) => abort('glTexGeni: TODO'),
+  glTexGenfv: (coord, pname, param) => abort('glTexGenfv: TODO'),
   glTexEnvi: (target, pname, params) => warnOnce('glTexEnvi: TODO'),
   glTexEnvf: (target, pname, params) => warnOnce('glTexEnvf: TODO'),
   glTexEnvfv: (target, pname, params) => warnOnce('glTexEnvfv: TODO'),
 
-  glGetTexEnviv: (target, pname, param) => { throw 'GL emulation not initialized!'; },
-  glGetTexEnvfv: (target, pname, param) => { throw 'GL emulation not initialized!'; },
+  glGetTexEnviv: (target, pname, param) => abort('GL emulation not initialized!'),
+  glGetTexEnvfv: (target, pname, param) => abort('GL emulation not initialized!'),
 
-  glTexImage1D: (target, level, internalformat, width, border, format, type, data) => { throw 'glTexImage1D: TODO' },
-  glTexCoord3f: (target, level, internalformat, width, border, format, type, data) => { throw 'glTexCoord3f: TODO' },
-  glGetTexLevelParameteriv: (target, level, pname, params) => { throw 'glGetTexLevelParameteriv: TODO' },
+  glTexImage1D: (target, level, internalformat, width, border, format, type, data) => abort('glTexImage1D: TODO'),
+  glTexCoord3f: (target, level, internalformat, width, border, format, type, data) => abort('glTexCoord3f: TODO'),
+  glGetTexLevelParameteriv: (target, level, pname, params) => abort('glGetTexLevelParameteriv: TODO'),
 
   glShadeModel: () => warnOnce('TODO: glShadeModel'),