Remove inner loop from test_js_function_names_are_minified. NFC (#25155)

Also remove unneeded `-Wno-closure`.

Author: sbc100

test/test_other.py

@@ -11810,6 +11810,8 @@ def test_linking_send(self):
 
   # This test verifies that function names embedded into the build with --js-library (JS functions exported to wasm)
   # are minified when -O3 is used
+  # Currently we rely on Closure for full minification of every appearance of JS function names.
+  # TODO: Add minification also for non-Closure users and add a non-closure config to this test.
   @is_slow_test
   @also_with_wasm2js
   def test_js_function_names_are_minified(self):
@@ -11822,17 +11824,11 @@ def check_size(f, expected_size):
       self.assertLess(obtained_size, expected_size)
 
     self.run_process([PYTHON, test_file('gen_many_js_functions.py'), 'library_long.js', 'main_long.c'])
-    # Currently we rely on Closure for full minification of every appearance of JS function names.
-    # TODO: Add minification also for non-Closure users and add [] to this list to test minification without Closure.
-    for closure in [['--closure=1', '-Wno-closure']]:
-      args = [EMCC, '-O3', '--js-library', 'library_long.js', 'main_long.c'] + self.get_cflags() + closure
-      self.run_process(args)
-
-      ret = self.run_js('a.out.js')
-      self.assertTextDataIdentical('Sum of numbers from 1 to 1000: 500500 (expected 500500)', ret.strip())
+    ret = self.do_runf('main_long.c', cflags=['-O3', '--js-library', 'library_long.js', '--closure=1'])
+    self.assertTextDataIdentical('Sum of numbers from 1 to 1000: 500500 (expected 500500)', ret.strip())
 
-      check_size('a.out.js', 150000)
-      check_size('a.out.wasm', 80000)
+    check_size('a.out.js', 150000)
+    check_size('a.out.wasm', 80000)
 
   # Checks that C++ exceptions managing invoke_*() wrappers will not be generated if exceptions are disabled
   def test_no_invoke_functions_are_generated_if_exception_catching_is_disabled(self):