Added synchronisation directives in WeakValueMap #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This correct various random crashes occuring with Internet Explorer when push updates are used.
MatthiasVC
force-pushed
the
master
branch
2 times, most recently
from
6bcbcdb to
51d8acb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Can you please merge this change?
I introduced locking directives in WeakValueMap, which prevents two threads from manipulating the underlying map at the same time. This eliminated the handful of crashes that were directly relating to this class - but also a whole suite of random crashes and session resets with Internet Explorer as client.
Thanks!
JB