Merge pull request #215 from enter-at/feat/tests-for-successful-responses

Tests for successful HTTP responses

Author: Martin Pirkl

README.md

@@ -257,9 +257,13 @@ See [LICENSE](LICENSE) for full details.
 
 [![Steffen Leistner][sleistner_avatar]][sleistner_homepage]
 
+[![Martin Pirkl][pirklmar_avatar]][pirklmar_homepage]
+
 
   [sleistner_homepage]: https://github.com/sleistner
   [sleistner_avatar]: https://res.cloudinary.com/enter-at/image/fetch/f_png,r_max,w_100,h_100,c_thumb/https://github.com/sleistner.png
+  [pirklmar_homepage]: https://github.com/pirklmar
+  [pirklmar_avatar]: https://res.cloudinary.com/enter-at/image/fetch/f_png,r_max,w_100,h_100,c_thumb/https://github.com/pirklmar.png
 
 
 

README.yaml

@@ -65,3 +65,5 @@ include:
 contributors:
     - name: "Steffen Leistner"
       github: "sleistner"
+    - name: "Martin Pirkl"
+      github: "pirklmar"

package.json

@@ -30,6 +30,9 @@
         "Typescript"
     ],
     "author": "Steffen Leistner",
+    "contributors": [
+        "Martin Pirkl <[email protected]>"
+    ],
     "license": "Apache-2.0",
     "bugs": {
         "url": "https://github.com/enter-at/node-aws-lambda-handlers/issues"

src/handler/APIGatewayProxyHandler.spec.ts

@@ -9,6 +9,7 @@ import {
     ForbiddenError,
     BadRequestError,
 } from "../error";
+import { ok, created, noContent } from '../response'
 import * as ContextFactory from "../../test/fixtures/ContextFactory";
 import * as APIGatewayProxyEventFactory from "../../test/fixtures/APIGatewayProxyEventFactory";
 
@@ -23,6 +24,33 @@ describe(APIGatewayProxyHandler.name, () => {
         event = APIGatewayProxyEventFactory.factory();
     });
 
+    it("handles HTTP 200 response correctly", async () => {
+        const fn = handler.wrapper(() => {
+            return ok({ result: "HTTP 200" })
+        }) as Handler<APIGatewayProxyEvent, APIGatewayProxyResult>;
+
+        const result = await fn(event, context, () => {});
+        expect(result).toMatchSnapshot();
+    });
+
+    it("handles HTTP 201 response correctly", async () => {
+        const fn = handler.wrapper(() => {
+            return created({ result: "HTTP 201" })
+        }) as Handler<APIGatewayProxyEvent, APIGatewayProxyResult>;
+
+        const result = await fn(event, context, () => {});
+        expect(result).toMatchSnapshot();
+    });
+
+    it("handles HTTP 204 response correctly", async () => {
+        const fn = handler.wrapper(() => {
+            return noContent()
+        }) as Handler<APIGatewayProxyEvent, APIGatewayProxyResult>;
+
+        const result = await fn(event, context, () => {});
+        expect(result).toMatchSnapshot();
+    });
+
     it("handles BadRequestError response correctly", async () => {
         const fn = handler.wrapper(() => {
             throw new BadRequestError("BadRequestError message");

src/handler/__snapshots__/APIGatewayProxyHandler.spec.ts.snap

@@ -36,6 +36,41 @@ Object {
 }
 `;
 
+exports[`APIGatewayProxyHandler handles HTTP 200 response correctly 1`] = `
+Object {
+  "body": "{\\"result\\":\\"HTTP 200\\"}",
+  "headers": Object {
+    "Access-Control-Allow-Credentials": true,
+    "Access-Control-Allow-Origin": "*",
+    "Content-Type": "application/json",
+  },
+  "statusCode": 200,
+}
+`;
+
+exports[`APIGatewayProxyHandler handles HTTP 201 response correctly 1`] = `
+Object {
+  "body": "{\\"result\\":\\"HTTP 201\\"}",
+  "headers": Object {
+    "Access-Control-Allow-Credentials": true,
+    "Access-Control-Allow-Origin": "*",
+    "Content-Type": "application/json",
+  },
+  "statusCode": 201,
+}
+`;
+
+exports[`APIGatewayProxyHandler handles HTTP 204 response correctly 1`] = `
+Object {
+  "headers": Object {
+    "Access-Control-Allow-Credentials": true,
+    "Access-Control-Allow-Origin": "*",
+    "Content-Type": "application/json",
+  },
+  "statusCode": 204,
+}
+`;
+
 exports[`APIGatewayProxyHandler handles InternalServerError response correctly 1`] = `
 Object {
   "body": "{\\"errors\\":[{\\"name\\":\\"InternalServerError\\",\\"details\\":\\"InternalServerError\\"}]}",