Skip to content

Test Suite is using GuiToolAssistant as a way to check if toolkit is Qt  #553

@kitchoi

Description

@kitchoi

While I was working on #552, I realized skipping the Qt-specific test case using the skipIf(toolkit_object.toolkit != "qt4", ...) was not enough, I also had to add a skipIf(GuiTestAssistant.__name__ == "Unimplemented", ...).

This suggests that tests that require Qt, e.g. because the test body contain Qt specific code, are skipped relying on the fact that GuiTestAssistant is only implemented for Qt. This is not ideal, because as soon as GuiTestAssistant is implemented for other toolkit (e.g. wx, see #266), these tests will be run erroneously, causing build errors.

Metadata

Metadata

Assignees

No one assigned

    Labels

    component: test suiteIssues related to testing, test support, test interactions...

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions