Skip to content

Conversation

@leonm1
Copy link
Contributor

@leonm1 leonm1 commented Aug 29, 2025

Commit Message:
cel: add support for re-evaluating CEL expression on response path

Additional Description:
Changes the CEL expression data input to return MoreDataMightBeAvailable if any of request_headers, response_headers, or response_trailers is not available at the time of evaluation.

Re-evaluates CEL expression iff the response data was attempted to be read during the first (request phase) evaluation AND the expression result was no-match.

If the expression was a match, (aiui) the matcher will not call the CEL matcher's match function again.

If the expression was not a match and the response data was NOT evaluated in the CEL expression, then the no-match result is cached for the next filter callback. The matcher will re-invoke the CEL matcher's match function, but the match function will just return the cached result.

Risk Level: medium. Modification of existing work-in-progress filter.
Testing: Unit tested in test/extensions/matching/input_matchers/cel_matcher/cel_matcher_test.cc, manual end-to-end testing done.

Docs Changes: None.
Release Notes: Added note to current release notes.
Platform Specific Features:
Runtime guard: None.

@leonm1 leonm1 force-pushed the cel/response_headers branch from f815564 to 2a35ff3 Compare August 29, 2025 21:11
@leonm1
Copy link
Contributor Author

leonm1 commented Aug 29, 2025

@yanavlasov this is the PR we discussed would come after #40800. PTAL at your earliest convenience!

@kyessenov
Copy link
Contributor

@leonm1 please mark as ready to receive reviews. I'll assign to Yan, but they can re-assign if needed.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 2, 2025
@github-actions
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale stalebot believes this issue/PR has not been touched recently

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants