fix: DualStack NodePort Gateway's status.addresses should contain addresses from both IP families
#6372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oth families Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
fix/node-port-gateway-dualstack
branch
from
3cf1a05 to
48d0c8c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6372 +/- ##
==========================================
+ Coverage 70.74% 70.79% +0.04%
==========================================
Files 220 220
Lines 37581 37594 +13
==========================================
+ Hits 26588 26613 +25
+ Misses 9429 9420 -9
+ Partials 1564 1561 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
fix/node-port-gateway-dualstack
branch
from
48d0c8c to
4c37a1f
Compare
arkodg
reviewed
Jun 23, 2025
Signed-off-by: Mike Beaumont <[email protected]>
arkodg
approved these changes
Jul 8, 2025
zirain
approved these changes
Jul 8, 2025
davem-git
pushed a commit
to davem-git/gateway
that referenced
this pull request
Jul 8, 2025
…ddresses from both IP families (envoyproxy#6372) * fix: DualStack NodePort Gateway's `status.addresses` should contain both families Signed-off-by: Mike Beaumont <[email protected]> * test: update existing Signed-off-by: Mike Beaumont <[email protected]> * test: new cases Signed-off-by: Mike Beaumont <[email protected]> * chore: changelog Signed-off-by: Mike Beaumont <[email protected]> --------- Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: zirain <[email protected]>
kkk777-7
pushed a commit
to kkk777-7/gateway
that referenced
this pull request
Jul 9, 2025
…ddresses from both IP families (envoyproxy#6372) * fix: DualStack NodePort Gateway's `status.addresses` should contain both families Signed-off-by: Mike Beaumont <[email protected]> * test: update existing Signed-off-by: Mike Beaumont <[email protected]> * test: new cases Signed-off-by: Mike Beaumont <[email protected]> * chore: changelog Signed-off-by: Mike Beaumont <[email protected]> --------- Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: zirain <[email protected]>
tjvdmolen
pushed a commit
to tjvdmolen/gateway
that referenced
this pull request
Jul 11, 2025
…ddresses from both IP families (envoyproxy#6372) * fix: DualStack NodePort Gateway's `status.addresses` should contain both families Signed-off-by: Mike Beaumont <[email protected]> * test: update existing Signed-off-by: Mike Beaumont <[email protected]> * test: new cases Signed-off-by: Mike Beaumont <[email protected]> * chore: changelog Signed-off-by: Mike Beaumont <[email protected]> --------- Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: zirain <[email protected]> Signed-off-by: Tjeerd Jan van der Molen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: DualStack NodePort Gateway's
status.addressesshould contain addresses from both IP familiesWhat this PR does / why we need it:
Fixes the Gateway status reconciliation with a DualStack NodePort Gateway to include addresses of both families for every node if they're present.
Which issue(s) this PR fixes:
Fixes #6371
Release Notes: Yes