fix: custom backend weight not set properly #6468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bitliu <[email protected]>
Xunzhuo
force-pushed
the
fix-custom-backend-weight
branch
from
ee29892 to
07b6494
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6468 +/- ##
=======================================
Coverage 70.77% 70.78%
=======================================
Files 220 220
Lines 37576 37582 +6
=======================================
+ Hits 26596 26602 +6
+ Misses 9422 9420 -2
- Partials 1558 1560 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhaohuabing
approved these changes
Jul 4, 2025
davem-git
pushed a commit
to davem-git/gateway
that referenced
this pull request
Jul 8, 2025
Signed-off-by: bitliu <[email protected]>
tjvdmolen
pushed a commit
to tjvdmolen/gateway
that referenced
this pull request
Jul 11, 2025
Signed-off-by: bitliu <[email protected]> Signed-off-by: Tjeerd Jan van der Molen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR fixed the custom backendRef weight not set properly, which will cause the destination settings empty and always get a 500 direct response.
This fix has tested in envoy ai gateway.