Merge pull request #79 from carlbennettnz/loosen-media-type-restriction

Remove media type check

Author: ethanresnick

src/steps/http/content-negotiation/validate-content-type.js

@@ -6,6 +6,10 @@ import {objectIsEmpty} from "../../../util/type-handling";
 export default function validateContentType(requestContext, supportedExt) {
   return Q.Promise(function(resolve, reject) {
     let contentType = contentTypeParser.parse(requestContext.contentType);
+    
+    // Removed due to issues with Firefox automatically adding charset parameter
+    // See: https://github.com/ethanresnick/json-api/issues/78
+    delete contentType.parameters.charset;
 
     // In the future, we might delegate back to the framework if the client
     // provides a base content type other than json-api's. But, for now, we 415.

test/integration/content-negotiation/index.js

@@ -23,6 +23,19 @@ AgentPromise.then((Agent) => {
         }).catch(done);
     });
 
+    // Spec ignored due to issues with Firefox automatically adding charset parameter
+    // See: https://github.com/ethanresnick/json-api/issues/78
+    it("must accept charset parameter", (done) => {
+      Agent.request("POST", "/organizations")
+        .type("application/vnd.api+json;charset=utf-8")
+        .send({"data": VALID_ORG_RESOURCE_NO_ID})
+        .promise()
+        .then((res) => {
+          expect(res.status).to.equal(201);
+          done();
+        }, done).catch(done);
+    });
+
     // "Servers MUST send all JSON API data in response documents with the
     //  header Content-Type: application/vnd.api+json without any media type
     //  parameters."