refactor(consume): create explicit pytest plugin structure (#1801)

* refactor(consume): rename `hive_simulators` to `simulators`.

* refactor(consume): move helper modules to a new `helpers` sub-package

* refactor(consume): rename `conftest` to `single_test_client` plugin

Plugins called 'conftest' are registered automatically if in a sub-path to a test. This rename requires an explicit registration, which is specified by defining the `pytest_plugins` variable in 'engine/conftest.py', respectively, 'rlp/conftest.py'.

* refactor(consume): split into separate plugins by functionality

* refactor(consume): split base functionality out to the `base` plugin

These are fixtures that can also be shared by multi-client architecture simulators.

* fix(consume): add `genesis_header` to `single_test_cilent` plugin

* refactor(consume): move test execution files to shared hive_tests directory

Consolidate test_via_engine.py and test_via_rlp.py into a shared hive_tests/
directory to improve organization and prepare for future multi-client architectures.

- Create src/pytest_plugins/consume/simulators/hive_tests/ directory.
- Move test_via_engine.py from engine/ to hive_tests/.
- Move test_via_rlp.py from rlp/ to hive_tests/.
- Update get_command_paths() to reference new locations.
- Maintain separation: plugin configs (conftest.py) stay with their simulators.

This provides better logical organization of test execution files while
maintaining explicit pytest plugin structure.

* fix(consume): add explicit plugin registration for simulator-specific configs

With the move to hive_tests/, the simulator-specific conftest.py files are no
longer automatically discovered. Add explicit plugin registration to ensure
_supported_fixture_formats and other simulator configs are properly loaded.

- Add command_name parameter to HiveEnvironmentProcessor.
- Register simulator-specific plugins based on command name.
- Update ConsumeCommand to pass command_name to processors.
- Fix AttributeError: 'Config' object has no attribute '_supported_fixture_formats'.

* docs: add changelog entry for consume simulator refactor (#1801)

* refactor(consume): move pytest_hive plugin registration to simulator conftest files

Move pytest_hive plugin registration from HiveEnvironmentProcessor to individual
simulator conftest files to centralize all plugin configuration in one place
per simulator.

* chore(cli): remove verbose docstring to keep reviewers happy

Author: danceratopz

docs/CHANGELOG.md

@@ -42,6 +42,7 @@ Users can select any of the artifacts depending on their testing needs for their
 #### `consume`
 
 - 🔀 `consume` now automatically avoids GitHub API calls when using direct release URLs (better for CI environments), while release specifiers like `stable@latest` continue to use the API for version resolution ([#1788](https://github.com/ethereum/execution-spec-tests/pull/1788)).
+- 🔀 Refactor consume simulator architecture to use explicit pytest plugin structure with forward-looking architecture ([#1801](https://github.com/ethereum/execution-spec-tests/pull/1801)).
 
 #### `execute`
 

pytest-framework.ini

@@ -13,7 +13,7 @@ addopts =
     --ignore=src/pytest_plugins/consume/test_cache.py
     --ignore=src/pytest_plugins/consume/direct/
     --ignore=src/pytest_plugins/consume/direct/test_via_direct.py
-    --ignore=src/pytest_plugins/consume/hive_simulators/
-    --ignore=src/pytest_plugins/consume/hive_simulators/engine/test_via_engine.py
-    --ignore=src/pytest_plugins/consume/hive_simulators/rlp/test_via_rlp.py
+    --ignore=src/pytest_plugins/consume/simulators/
+    --ignore=src/pytest_plugins/consume/simulators/engine/test_via_engine.py
+    --ignore=src/pytest_plugins/consume/simulators/rlp/test_via_rlp.py
     --ignore=src/pytest_plugins/execute/test_recover.py

src/cli/extract_config.py

@@ -23,7 +23,7 @@
 from ethereum_test_fixtures.file import Fixtures
 from ethereum_test_fixtures.pre_alloc_groups import PreAllocGroup
 from ethereum_test_forks import Fork
-from pytest_plugins.consume.hive_simulators.ruleset import ruleset
+from pytest_plugins.consume.simulators.helpers.ruleset import ruleset
 
 
 def get_docker_containers() -> set[str]:

src/cli/pytest_commands/consume.py

@@ -13,14 +13,14 @@
 class ConsumeCommand(PytestCommand):
     """Pytest command for consume operations."""
 
-    def __init__(self, command_paths: List[Path], is_hive: bool = False):
+    def __init__(self, command_paths: List[Path], is_hive: bool = False, command_name: str = ""):
         """Initialize consume command with paths and processors."""
         processors: List[ArgumentProcessor] = [HelpFlagsProcessor("consume")]
 
         if is_hive:
             processors.extend(
                 [
-                    HiveEnvironmentProcessor(),
+                    HiveEnvironmentProcessor(command_name=command_name),
                     ConsumeCommandProcessor(is_hive=True),
                 ]
             )
@@ -54,13 +54,15 @@ def get_command_paths(command_name: str, is_hive: bool) -> List[Path]:
     base_path = Path("src/pytest_plugins/consume")
     if command_name == "hive":
         commands = ["rlp", "engine"]
+        command_paths = [
+            base_path / "simulators" / "hive_tests" / f"test_via_{cmd}.py" for cmd in commands
+        ]
+    elif command_name in ["engine", "rlp"]:
+        command_paths = [base_path / "simulators" / "hive_tests" / f"test_via_{command_name}.py"]
+    elif command_name == "direct":
+        command_paths = [base_path / "direct" / "test_via_direct.py"]
     else:
-        commands = [command_name]
-
-    command_paths = [
-        base_path / ("hive_simulators" if is_hive else "") / cmd / f"test_via_{cmd}.py"
-        for cmd in commands
-    ]
+        raise ValueError(f"Unexpected command: {command_name}.")
     return command_paths
 
 
@@ -86,7 +88,7 @@ def decorator(func: Callable[..., Any]) -> click.Command:
         @common_pytest_options
         @functools.wraps(func)
         def command(pytest_args: List[str], **kwargs) -> None:
-            consume_cmd = ConsumeCommand(command_paths, is_hive)
+            consume_cmd = ConsumeCommand(command_paths, is_hive, command_name)
             consume_cmd.execute(list(pytest_args))
 
         return command

src/cli/pytest_commands/processors.py

@@ -74,6 +74,10 @@ def _is_writing_to_stdout(self, args: List[str]) -> bool:
 class HiveEnvironmentProcessor(ArgumentProcessor):
     """Processes Hive environment variables for consume commands."""
 
+    def __init__(self, command_name: str):
+        """Initialize the processor with command name to determine plugin."""
+        self.command_name = command_name
+
     def process_args(self, args: List[str]) -> List[str]:
         """Convert hive environment variables into pytest flags."""
         modified_args = args[:]
@@ -92,8 +96,12 @@ def process_args(self, args: List[str]) -> List[str]:
         if os.getenv("HIVE_LOGLEVEL") is not None:
             warnings.warn("HIVE_LOG_LEVEL is not yet supported.", stacklevel=2)
 
-        modified_args.extend(["-p", "pytest_plugins.pytest_hive.pytest_hive"])
-
+        if self.command_name == "engine":
+            modified_args.extend(["-p", "pytest_plugins.consume.simulators.engine.conftest"])
+        elif self.command_name == "rlp":
+            modified_args.extend(["-p", "pytest_plugins.consume.simulators.rlp.conftest"])
+        else:
+            raise ValueError(f"Unknown command name: {self.command_name}")
         return modified_args
 
     def _has_regex_or_sim_limit(self, args: List[str]) -> bool: