Skip to content

Optimize the json_infra tests #1605

@SamWilsn

Description

@SamWilsn

The tests/json_infra folder contains two types of tests (at least at the time of writing): unit tests for EELS, and tests that execute the JSON fixtures created by EEST. For the purposes of this issue, we're going to ignore our unit tests and focus on the JSON fixtures.

The intent of the json_infra tests is to ensure that EELS is capable of executing the filled JSON fixtures, and not verifying that we correctly implement the Ethereum specification. The py3 and pypy3 workflows are responsible for correctness.

With that in mind, there's absolutely no reason for json_infra to take several hours to run.


My plan (and feel free to come up with a completely different approach), is to use https://github.com/SamWilsn/minimize-tests to generate a minimum set of tests that cover everything, and adding --cov-fail-under=MIN to force us to regenerate the set when necessary.


Another thought: #1666 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhanceCategory: an improvement or new featureE-hardExperience: difficult, probably not for the faint of heart

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions