From f1bdad5d96e9480231012476eace4608f1019ad5 Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Wed, 26 Jun 2024 12:18:46 +0300 Subject: [PATCH 1/4] fix developer-guide.md --- docs/developer-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/developer-guide.md b/docs/developer-guide.md index 0ae2593..b7ab24c 100644 --- a/docs/developer-guide.md +++ b/docs/developer-guide.md @@ -35,7 +35,7 @@ npm run lint ## Travis-ci and Coveralls Testing -Note, this will generate a `coveralls` report locally. +Note, that this will generate a `coveralls` report locally. ``` npm run test-travis From 9c1beb13864c40f134c10ac441bb477e6016a9f1 Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Wed, 26 Jun 2024 12:19:18 +0300 Subject: [PATCH 2/4] fix user-guide.md --- docs/user-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/user-guide.md b/docs/user-guide.md index 77e3d69..1b78821 100644 --- a/docs/user-guide.md +++ b/docs/user-guide.md @@ -149,7 +149,7 @@ Error handling is done through function callbacks or promised catches. ## Browser Builds -`ethjs` provides production distributions for all of its modules that are ready for use in the browser right away. Simply include either `dist/ethjs-query.js` or `dist/ethjs-query.min.js` directly into an HTML file to start using this module. Note, an `Eth` object is made available globally. +`ethjs` provides production distributions for all of its modules that are ready for use in the browser right away. Simply include either `dist/ethjs-query.js` or `dist/ethjs-query.min.js` directly into an HTML file to start using this module. Note, that an `Eth` object is made available globally. ```html From af05ea009fa8866de3a8acfbdb8e2269414f4c5f Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Wed, 26 Jun 2024 12:20:01 +0300 Subject: [PATCH 3/4] fix index.js --- src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index 716ef9f..acb4dc0 100644 --- a/src/index.js +++ b/src/index.js @@ -52,7 +52,7 @@ function generateFnFor(rpcMethodName, methodObject) { return promiseToCallback(promise)(callback); } - // only return promise if no callback provided + //Only return promise if no callback is provided return promise; async function performCall() { From 50c8375c922c2e7a43382cc45dcd34d6fe5e152a Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Wed, 26 Jun 2024 12:20:48 +0300 Subject: [PATCH 4/4] fix CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 60e9f5a..8534c67 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ # 0.3.4 -- added new ethjs-format -1. Unhandled promise rejection fixed, and is no longer being swolloed. +1. Unhandled promise rejection fixed, and is no longer being swallowed. 2. ethjs-rpc bump to 0.1.9 # 0.2.6 -- added new ethjs-format