Skip to content

Commit 18e3252

Browse files
Allow explicit typing on Selector using TypeVar with default Any (#932)
1 parent 059f78b commit 18e3252

File tree

3 files changed

+44
-8
lines changed

3 files changed

+44
-8
lines changed

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ dynamic = ["version"]
5555
dependencies = [
5656
# typing.Annotated since v3.9
5757
# typing.Self and typing.assert_never since v3.11
58-
"typing-extensions; python_version<'3.11'",
58+
# typing.TypeVar default since v3.13
59+
"typing-extensions; python_version<'3.13'",
5960
]
6061

6162
[project.optional-dependencies]

src/dependency_injector/providers.pyi

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ from contextlib import AbstractContextManager, AbstractAsyncContextManager
44
from pathlib import Path
55
from typing import (
66
Awaitable,
7-
TypeVar,
87
Generic,
98
Type,
109
Callable as _Callable,
@@ -22,6 +21,8 @@ from typing import (
2221
overload,
2322
)
2423

24+
from typing_extensions import Self as _Self, TypeVar
25+
2526
try:
2627
import yaml
2728
except ImportError:
@@ -38,6 +39,7 @@ Injection = Any
3839
ProviderParent = Union["Provider", Any]
3940
T = TypeVar("T")
4041
TT = TypeVar("TT")
42+
T_Any = TypeVar("T_Any", default=Any)
4143
P = TypeVar("P", bound="Provider")
4244
BS = TypeVar("BS", bound="BaseSingleton")
4345

@@ -542,17 +544,17 @@ class Container(Provider[T]):
542544
def parent_name(self) -> Optional[str]: ...
543545
def assign_parent(self, parent: ProviderParent) -> None: ...
544546

545-
class Selector(Provider[Any]):
547+
class Selector(Provider[T_Any]):
546548
def __init__(
547549
self, selector: Optional[_Callable[..., Any]] = None, **providers: Provider
548550
): ...
549-
def __getattr__(self, name: str) -> Provider: ...
551+
def __getattr__(self, name: str) -> Provider[T_Any]: ...
550552
@property
551553
def selector(self) -> Optional[_Callable[..., Any]]: ...
552-
def set_selector(self, selector: Optional[_Callable[..., Any]]) -> Selector: ...
554+
def set_selector(self, selector: Optional[_Callable[..., Any]]) -> _Self: ...
553555
@property
554-
def providers(self) -> _Dict[str, Provider]: ...
555-
def set_providers(self, **providers: Provider) -> Selector: ...
556+
def providers(self) -> _Dict[str, Provider[T_Any]]: ...
557+
def set_providers(self, **providers: Provider) -> _Self: ...
556558

557559
class ProvidedInstanceFluentInterface:
558560
def __getattr__(self, item: Any) -> AttributeGetter: ...

tests/typing/selector.py

Lines changed: 34 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from typing import Any
1+
from typing import Any, Callable, Optional, Dict
22

33
from dependency_injector import providers
44

@@ -40,3 +40,36 @@
4040
async def _async4() -> None:
4141
var1: Any = await provider4()
4242
var2: Any = await provider4.async_()
43+
44+
45+
# Test 5: to check selector getter and setter
46+
provider5 = providers.Selector(
47+
lambda: "a",
48+
a=providers.Factory(object),
49+
b=providers.Factory(object),
50+
)
51+
selector5: Optional[Callable[..., Any]] = provider5.selector
52+
provider5_after_set_selector: providers.Selector[Any] = provider5.set_selector(lambda: "a")
53+
54+
# Test 6: to check providers getter and setter
55+
provider6 = providers.Selector(
56+
lambda: "a",
57+
a=providers.Factory(object),
58+
b=providers.Factory(object),
59+
)
60+
providers6: Dict[str, providers.Provider[Any]] = provider6.providers
61+
provider6_after_set_providers: providers.Selector[Any] = provider6.set_providers(c=providers.Factory(object))
62+
63+
64+
# Test 7: to check explicit typing: return type, getattr, getter/setter of providers and selectors
65+
provider7 = providers.Selector[bool](lambda: "a", a=providers.Factory(bool), b=providers.Factory(int))
66+
var7: bool = provider7()
67+
attr7: providers.Provider[bool] = provider7.a
68+
69+
selector7: Optional[Callable[..., Any]] = provider7.selector
70+
provider7_after_set_selector: providers.Selector[bool] = provider7.set_selector(lambda: "a")
71+
72+
providers7: Dict[str, providers.Provider[bool]] = provider7.providers
73+
provider7_after_set_providers: providers.Selector[bool] = provider7.set_providers(
74+
c=providers.Factory(str)
75+
) # We don't require Provider of subclass of bool yet since Provider is invariant

0 commit comments

Comments
 (0)