Skip to content

Commit 3678bdd

Browse files
CodemodService Botfacebook-github-bot
authored andcommitted
Fix CQS signal readability-avoid-const-params-in-decls in xplat/js/react-native-github/packages
Reviewed By: javache Differential Revision: D82939801
1 parent e1a6c38 commit 3678bdd

File tree

7 files changed

+20
-24
lines changed

7 files changed

+20
-24
lines changed

packages/react-native/React/CoreModules/RCTAppearance.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#import <React/RCTEventEmitter.h>
1313

1414
RCT_EXTERN void RCTEnableAppearancePreference(BOOL enabled);
15-
RCT_EXTERN void RCTOverrideAppearancePreference(NSString *const);
15+
RCT_EXTERN void RCTOverrideAppearancePreference(NSString *);
1616
RCT_EXTERN void RCTUseKeyWindowForSystemStyle(BOOL useMainScreen);
1717
RCT_EXTERN NSString *RCTCurrentOverrideAppearancePreference(void);
1818
RCT_EXTERN NSString *RCTColorSchemePreference(UITraitCollection *traitCollection);

packages/react-native/React/Views/RCTBorderDrawing.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ RCT_EXTERN CGPathRef RCTPathCreateWithRoundedRect(
6161
CGRect bounds,
6262
RCTCornerInsets cornerInsets,
6363
const CGAffineTransform *transform,
64-
const BOOL inverted);
64+
BOOL inverted);
6565

6666
/**
6767
* Draw a CSS-compliant border as an image. You can determine if it's scalable

packages/react-native/ReactAndroid/src/main/jni/react/jni/JReactMarker.h

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,20 +24,18 @@ class JReactMarker : public facebook::jni::JavaClass<JReactMarker> {
2424
private:
2525
static void logMarker(const std::string& marker);
2626
static void logMarker(const std::string& marker, const std::string& tag);
27-
static void logMarker(
28-
const std::string& marker,
29-
const std::string& tag,
30-
const int instanceKey);
27+
static void
28+
logMarker(const std::string& marker, const std::string& tag, int instanceKey);
3129
static void logPerfMarker(
32-
const ReactMarker::ReactMarkerId markerId,
30+
ReactMarker::ReactMarkerId markerId,
3331
const char* tag);
3432
static void logPerfMarkerBridgeless(
35-
const ReactMarker::ReactMarkerId markerId,
33+
ReactMarker::ReactMarkerId markerId,
3634
const char* tag);
3735
static void logPerfMarkerWithInstanceKey(
38-
const ReactMarker::ReactMarkerId markerId,
36+
ReactMarker::ReactMarkerId markerId,
3937
const char* tag,
40-
const int instanceKey);
38+
int instanceKey);
4139
static void nativeLogMarker(
4240
jni::alias_ref<jclass> /* unused */,
4341
const std::string& markerNameStr,

packages/react-native/ReactCommon/cxxreact/JSExecutor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ class RN_EXPORT [[deprecated(
106106
* necessary native modules methods.
107107
*/
108108
virtual void invokeCallback(
109-
const double callbackId,
109+
double callbackId,
110110
const folly::dynamic& arguments) = 0;
111111

112112
virtual void setGlobalVariable(

packages/react-native/ReactCommon/cxxreact/JSIndexedRAMBundle.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@ class RN_EXPORT [[deprecated(
6161
};
6262

6363
void init();
64-
std::string getModuleCode(const uint32_t id) const;
65-
void readBundle(char* buffer, const std::streamsize bytes) const;
64+
std::string getModuleCode(uint32_t id) const;
65+
void readBundle(char* buffer, std::streamsize bytes) const;
6666
void readBundle(
6767
char* buffer,
68-
const std::streamsize bytes,
69-
const std::istream::pos_type position) const;
68+
std::streamsize bytes,
69+
std::istream::pos_type position) const;
7070

7171
mutable std::unique_ptr<std::istream> m_bundle;
7272
ModuleTable m_table;

packages/react-native/ReactCommon/cxxreact/ReactMarker.h

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,13 @@ extern RN_EXPORT std::shared_mutex logTaggedMarkerImplMutex;
5757
extern RN_EXPORT LogTaggedMarker logTaggedMarkerImpl;
5858
extern RN_EXPORT LogTaggedMarker logTaggedMarkerBridgelessImpl;
5959

60-
extern RN_EXPORT void logMarker(const ReactMarkerId markerId); // Bridge only
60+
extern RN_EXPORT void logMarker(ReactMarkerId markerId); // Bridge only
6161
extern RN_EXPORT void logTaggedMarker(
62-
const ReactMarkerId markerId,
62+
ReactMarkerId markerId,
6363
const char* tag); // Bridge only
64-
extern RN_EXPORT void logMarkerBridgeless(const ReactMarkerId markerId);
64+
extern RN_EXPORT void logMarkerBridgeless(ReactMarkerId markerId);
6565
extern RN_EXPORT void logTaggedMarkerBridgeless(
66-
const ReactMarkerId markerId,
66+
ReactMarkerId markerId,
6767
const char* tag);
6868

6969
struct ReactMarkerEvent {
@@ -76,7 +76,7 @@ class RN_EXPORT StartupLogger {
7676
public:
7777
static StartupLogger& getInstance();
7878

79-
void logStartupEvent(const ReactMarkerId markerId, double markerTime);
79+
void logStartupEvent(ReactMarkerId markerId, double markerTime);
8080
void reset();
8181
double getAppStartupStartTime();
8282
double getInitReactRuntimeStartTime();
@@ -101,8 +101,6 @@ class RN_EXPORT StartupLogger {
101101
// When the marker got logged from the platform, it will notify here. This is
102102
// used to collect react markers that are logged in the platform instead of in
103103
// C++.
104-
extern RN_EXPORT void logMarkerDone(
105-
const ReactMarkerId markerId,
106-
double markerTime);
104+
extern RN_EXPORT void logMarkerDone(ReactMarkerId markerId, double markerTime);
107105

108106
} // namespace facebook::react::ReactMarker

packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ class [[deprecated(
9191
const std::string& moduleId,
9292
const std::string& methodId,
9393
const folly::dynamic& arguments) override;
94-
void invokeCallback(const double callbackId, const folly::dynamic& arguments)
94+
void invokeCallback(double callbackId, const folly::dynamic& arguments)
9595
override;
9696
void setGlobalVariable(
9797
std::string propName,

0 commit comments

Comments
 (0)