From 9ef6911b76b7e1655545c3b036c188a59c27860a Mon Sep 17 00:00:00 2001 From: CodemodService Bot Date: Mon, 22 Sep 2025 20:02:15 -0700 Subject: [PATCH] Fix CQS signal readability-avoid-const-params-in-decls in xplat/js/react-native-github/packages (#53882) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/53882 Reviewed By: javache Differential Revision: D82939801 --- .../react-native/React/CoreModules/RCTAppearance.h | 2 +- .../react-native/React/Views/RCTBorderDrawing.h | 2 +- .../src/main/jni/react/jni/JReactMarker.h | 14 ++++++-------- .../react-native/ReactCommon/cxxreact/JSExecutor.h | 2 +- .../ReactCommon/cxxreact/JSIndexedRAMBundle.h | 8 ++++---- .../ReactCommon/cxxreact/ReactMarker.h | 14 ++++++-------- .../ReactCommon/jsiexecutor/jsireact/JSIExecutor.h | 2 +- 7 files changed, 20 insertions(+), 24 deletions(-) diff --git a/packages/react-native/React/CoreModules/RCTAppearance.h b/packages/react-native/React/CoreModules/RCTAppearance.h index df1b791015e467..5b8ad85b60ec20 100644 --- a/packages/react-native/React/CoreModules/RCTAppearance.h +++ b/packages/react-native/React/CoreModules/RCTAppearance.h @@ -12,7 +12,7 @@ #import RCT_EXTERN void RCTEnableAppearancePreference(BOOL enabled); -RCT_EXTERN void RCTOverrideAppearancePreference(NSString *const); +RCT_EXTERN void RCTOverrideAppearancePreference(NSString *); RCT_EXTERN void RCTUseKeyWindowForSystemStyle(BOOL useMainScreen); RCT_EXTERN NSString *RCTCurrentOverrideAppearancePreference(void); RCT_EXTERN NSString *RCTColorSchemePreference(UITraitCollection *traitCollection); diff --git a/packages/react-native/React/Views/RCTBorderDrawing.h b/packages/react-native/React/Views/RCTBorderDrawing.h index da0c04d6aa9e00..26c92fa5a76a3c 100644 --- a/packages/react-native/React/Views/RCTBorderDrawing.h +++ b/packages/react-native/React/Views/RCTBorderDrawing.h @@ -61,7 +61,7 @@ RCT_EXTERN CGPathRef RCTPathCreateWithRoundedRect( CGRect bounds, RCTCornerInsets cornerInsets, const CGAffineTransform *transform, - const BOOL inverted); + BOOL inverted); /** * Draw a CSS-compliant border as an image. You can determine if it's scalable diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/jni/JReactMarker.h b/packages/react-native/ReactAndroid/src/main/jni/react/jni/JReactMarker.h index 5fd4ab97baaf17..aab4af4d8c3ec2 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/jni/JReactMarker.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/jni/JReactMarker.h @@ -24,20 +24,18 @@ class JReactMarker : public facebook::jni::JavaClass { private: static void logMarker(const std::string& marker); static void logMarker(const std::string& marker, const std::string& tag); - static void logMarker( - const std::string& marker, - const std::string& tag, - const int instanceKey); + static void + logMarker(const std::string& marker, const std::string& tag, int instanceKey); static void logPerfMarker( - const ReactMarker::ReactMarkerId markerId, + ReactMarker::ReactMarkerId markerId, const char* tag); static void logPerfMarkerBridgeless( - const ReactMarker::ReactMarkerId markerId, + ReactMarker::ReactMarkerId markerId, const char* tag); static void logPerfMarkerWithInstanceKey( - const ReactMarker::ReactMarkerId markerId, + ReactMarker::ReactMarkerId markerId, const char* tag, - const int instanceKey); + int instanceKey); static void nativeLogMarker( jni::alias_ref /* unused */, const std::string& markerNameStr, diff --git a/packages/react-native/ReactCommon/cxxreact/JSExecutor.h b/packages/react-native/ReactCommon/cxxreact/JSExecutor.h index 246a8c464c6518..f65ab5d7af9384 100644 --- a/packages/react-native/ReactCommon/cxxreact/JSExecutor.h +++ b/packages/react-native/ReactCommon/cxxreact/JSExecutor.h @@ -106,7 +106,7 @@ class RN_EXPORT [[deprecated( * necessary native modules methods. */ virtual void invokeCallback( - const double callbackId, + double callbackId, const folly::dynamic& arguments) = 0; virtual void setGlobalVariable( diff --git a/packages/react-native/ReactCommon/cxxreact/JSIndexedRAMBundle.h b/packages/react-native/ReactCommon/cxxreact/JSIndexedRAMBundle.h index 1e6f8f1c5d43f5..dc7b9b3d436b21 100644 --- a/packages/react-native/ReactCommon/cxxreact/JSIndexedRAMBundle.h +++ b/packages/react-native/ReactCommon/cxxreact/JSIndexedRAMBundle.h @@ -61,12 +61,12 @@ class RN_EXPORT [[deprecated( }; void init(); - std::string getModuleCode(const uint32_t id) const; - void readBundle(char* buffer, const std::streamsize bytes) const; + std::string getModuleCode(uint32_t id) const; + void readBundle(char* buffer, std::streamsize bytes) const; void readBundle( char* buffer, - const std::streamsize bytes, - const std::istream::pos_type position) const; + std::streamsize bytes, + std::istream::pos_type position) const; mutable std::unique_ptr m_bundle; ModuleTable m_table; diff --git a/packages/react-native/ReactCommon/cxxreact/ReactMarker.h b/packages/react-native/ReactCommon/cxxreact/ReactMarker.h index 8b4a95234dc39b..9c2f2e7628cbf7 100644 --- a/packages/react-native/ReactCommon/cxxreact/ReactMarker.h +++ b/packages/react-native/ReactCommon/cxxreact/ReactMarker.h @@ -57,13 +57,13 @@ extern RN_EXPORT std::shared_mutex logTaggedMarkerImplMutex; extern RN_EXPORT LogTaggedMarker logTaggedMarkerImpl; extern RN_EXPORT LogTaggedMarker logTaggedMarkerBridgelessImpl; -extern RN_EXPORT void logMarker(const ReactMarkerId markerId); // Bridge only +extern RN_EXPORT void logMarker(ReactMarkerId markerId); // Bridge only extern RN_EXPORT void logTaggedMarker( - const ReactMarkerId markerId, + ReactMarkerId markerId, const char* tag); // Bridge only -extern RN_EXPORT void logMarkerBridgeless(const ReactMarkerId markerId); +extern RN_EXPORT void logMarkerBridgeless(ReactMarkerId markerId); extern RN_EXPORT void logTaggedMarkerBridgeless( - const ReactMarkerId markerId, + ReactMarkerId markerId, const char* tag); struct ReactMarkerEvent { @@ -76,7 +76,7 @@ class RN_EXPORT StartupLogger { public: static StartupLogger& getInstance(); - void logStartupEvent(const ReactMarkerId markerId, double markerTime); + void logStartupEvent(ReactMarkerId markerId, double markerTime); void reset(); double getAppStartupStartTime(); double getInitReactRuntimeStartTime(); @@ -101,8 +101,6 @@ class RN_EXPORT StartupLogger { // When the marker got logged from the platform, it will notify here. This is // used to collect react markers that are logged in the platform instead of in // C++. -extern RN_EXPORT void logMarkerDone( - const ReactMarkerId markerId, - double markerTime); +extern RN_EXPORT void logMarkerDone(ReactMarkerId markerId, double markerTime); } // namespace facebook::react::ReactMarker diff --git a/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h b/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h index 89347dd93b73e6..08f61341bcbdad 100644 --- a/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h +++ b/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h @@ -91,7 +91,7 @@ class [[deprecated( const std::string& moduleId, const std::string& methodId, const folly::dynamic& arguments) override; - void invokeCallback(const double callbackId, const folly::dynamic& arguments) + void invokeCallback(double callbackId, const folly::dynamic& arguments) override; void setGlobalVariable( std::string propName,