Skip to content

Commit 3082604

Browse files
authored
[DevTools] Feature detect sources panel (#33987)
I broke Firefox DevTools extension in #33968. It turns out the Firefox has a placeholder object for the sources panel which is empty. We need to detect the actual event handler.
1 parent 4f34cc4 commit 3082604

File tree

1 file changed

+2
-2
lines changed
  • packages/react-devtools-extensions/src/main

1 file changed

+2
-2
lines changed

packages/react-devtools-extensions/src/main/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ function createBridge() {
111111
chrome.devtools.panels.elements.onSelectionChanged.removeListener(
112112
onBrowserElementSelectionChanged,
113113
);
114-
if (sourcesPanel) {
114+
if (sourcesPanel && sourcesPanel.onSelectionChanged) {
115115
currentSelectedSource = null;
116116
sourcesPanel.onSelectionChanged.removeListener(
117117
onBrowserSourceSelectionChanged,
@@ -124,7 +124,7 @@ function createBridge() {
124124
chrome.devtools.panels.elements.onSelectionChanged.addListener(
125125
onBrowserElementSelectionChanged,
126126
);
127-
if (sourcesPanel) {
127+
if (sourcesPanel && sourcesPanel.onSelectionChanged) {
128128
sourcesPanel.onSelectionChanged.addListener(
129129
onBrowserSourceSelectionChanged,
130130
);

0 commit comments

Comments
 (0)