Skip to content

Commit c229707

Browse files
committed
[Fizz] Render preamble eagerly (#33730)
We unnecessarily render the preamble in a task. This updates the implementation to perform this render inline. Testing this is tricky because one of the only ways you could assert this was even happening is based on how things error if you abort while rendering the root. While adding a test for this I discovered that not all abortable tasks report errors when aborted during a normal render. I've asserted the current behavior and will address the other issue at another time and updated the assertion later as necessary DiffTrain build for [befc124](befc124)
1 parent 0efbfeb commit c229707

36 files changed

+210
-247
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
b44a99bf58d69d52b5288d9eadcc6d226d705e11
1+
befc1246b07a04b401bc6e914b7f336a442dca1a
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
b44a99bf58d69d52b5288d9eadcc6d226d705e11
1+
befc1246b07a04b401bc6e914b7f336a442dca1a

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1434,7 +1434,7 @@ __DEV__ &&
14341434
exports.useTransition = function () {
14351435
return resolveDispatcher().useTransition();
14361436
};
1437-
exports.version = "19.2.0-www-classic-b44a99bf-20250708";
1437+
exports.version = "19.2.0-www-classic-befc1246-20250708";
14381438
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14391439
"function" ===
14401440
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1434,7 +1434,7 @@ __DEV__ &&
14341434
exports.useTransition = function () {
14351435
return resolveDispatcher().useTransition();
14361436
};
1437-
exports.version = "19.2.0-www-modern-b44a99bf-20250708";
1437+
exports.version = "19.2.0-www-modern-befc1246-20250708";
14381438
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14391439
"function" ===
14401440
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,4 +610,4 @@ exports.useSyncExternalStore = function (
610610
exports.useTransition = function () {
611611
return ReactSharedInternals.H.useTransition();
612612
};
613-
exports.version = "19.2.0-www-classic-b44a99bf-20250708";
613+
exports.version = "19.2.0-www-classic-befc1246-20250708";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,4 +610,4 @@ exports.useSyncExternalStore = function (
610610
exports.useTransition = function () {
611611
return ReactSharedInternals.H.useTransition();
612612
};
613-
exports.version = "19.2.0-www-modern-b44a99bf-20250708";
613+
exports.version = "19.2.0-www-modern-befc1246-20250708";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ exports.useSyncExternalStore = function (
614614
exports.useTransition = function () {
615615
return ReactSharedInternals.H.useTransition();
616616
};
617-
exports.version = "19.2.0-www-classic-b44a99bf-20250708";
617+
exports.version = "19.2.0-www-classic-befc1246-20250708";
618618
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
619619
"function" ===
620620
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ exports.useSyncExternalStore = function (
614614
exports.useTransition = function () {
615615
return ReactSharedInternals.H.useTransition();
616616
};
617-
exports.version = "19.2.0-www-modern-b44a99bf-20250708";
617+
exports.version = "19.2.0-www-modern-befc1246-20250708";
618618
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
619619
"function" ===
620620
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19299,10 +19299,10 @@ __DEV__ &&
1929919299
(function () {
1930019300
var internals = {
1930119301
bundleType: 1,
19302-
version: "19.2.0-www-classic-b44a99bf-20250708",
19302+
version: "19.2.0-www-classic-befc1246-20250708",
1930319303
rendererPackageName: "react-art",
1930419304
currentDispatcherRef: ReactSharedInternals,
19305-
reconcilerVersion: "19.2.0-www-classic-b44a99bf-20250708"
19305+
reconcilerVersion: "19.2.0-www-classic-befc1246-20250708"
1930619306
};
1930719307
internals.overrideHookState = overrideHookState;
1930819308
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19336,7 +19336,7 @@ __DEV__ &&
1933619336
exports.Shape = Shape;
1933719337
exports.Surface = Surface;
1933819338
exports.Text = Text;
19339-
exports.version = "19.2.0-www-classic-b44a99bf-20250708";
19339+
exports.version = "19.2.0-www-classic-befc1246-20250708";
1934019340
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1934119341
"function" ===
1934219342
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19070,10 +19070,10 @@ __DEV__ &&
1907019070
(function () {
1907119071
var internals = {
1907219072
bundleType: 1,
19073-
version: "19.2.0-www-modern-b44a99bf-20250708",
19073+
version: "19.2.0-www-modern-befc1246-20250708",
1907419074
rendererPackageName: "react-art",
1907519075
currentDispatcherRef: ReactSharedInternals,
19076-
reconcilerVersion: "19.2.0-www-modern-b44a99bf-20250708"
19076+
reconcilerVersion: "19.2.0-www-modern-befc1246-20250708"
1907719077
};
1907819078
internals.overrideHookState = overrideHookState;
1907919079
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19107,7 +19107,7 @@ __DEV__ &&
1910719107
exports.Shape = Shape;
1910819108
exports.Surface = Surface;
1910919109
exports.Text = Text;
19110-
exports.version = "19.2.0-www-modern-b44a99bf-20250708";
19110+
exports.version = "19.2.0-www-modern-befc1246-20250708";
1911119111
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1911219112
"function" ===
1911319113
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)