Skip to content

Commit ccbdf63

Browse files
josephsavonajosephsavona
committed
[compiler] Fix for false positive mutation of destructured spread object (#33786)
When destructuring, spread creates a new mutable object that _captures_ part of the original rvalue. This new value is safe to modify. When making this change I realized that we weren't inferring array pattern spread as creating an array (in type inference) so I also added that here. DiffTrain build for [448f781](448f781)
1 parent e5d64ee commit ccbdf63

26 files changed

+215
-99
lines changed

‎compiled-rn/VERSION_NATIVE_FB

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-4f34cc4a-20250724
1+
19.2.0-native-fb-448f781a-20250724

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<36576a06e92c04401c7b6a51ba51b65e>>
10+
* @generated SignedSource<<83d39815a4810812a111302bf06628ff>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-4f34cc4a-20250724";
407+
exports.version = "19.2.0-native-fb-448f781a-20250724";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<19b337269316c827065a6292577a989b>>
10+
* @generated SignedSource<<40389899f516f743a6b6fe3c4c9372dd>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-4f34cc4a-20250724";
206+
exports.version = "19.2.0-native-fb-448f781a-20250724";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<19b337269316c827065a6292577a989b>>
10+
* @generated SignedSource<<40389899f516f743a6b6fe3c4c9372dd>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-4f34cc4a-20250724";
206+
exports.version = "19.2.0-native-fb-448f781a-20250724";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<7afe6f1dab6a762fecc3cd5f836c374c>>
10+
* @generated SignedSource<<68f3251ca9a0faab920550c012ae40fc>>
1111
*/
1212

1313
/*
@@ -29006,11 +29006,11 @@ __DEV__ &&
2900629006
};
2900729007
(function () {
2900829008
var isomorphicReactPackageVersion = React.version;
29009-
if ("19.2.0-native-fb-4f34cc4a-20250724" !== isomorphicReactPackageVersion)
29009+
if ("19.2.0-native-fb-448f781a-20250724" !== isomorphicReactPackageVersion)
2901029010
throw Error(
2901129011
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2901229012
(isomorphicReactPackageVersion +
29013-
"\n - react-dom: 19.2.0-native-fb-4f34cc4a-20250724\nLearn more: https://react.dev/warnings/version-mismatch")
29013+
"\n - react-dom: 19.2.0-native-fb-448f781a-20250724\nLearn more: https://react.dev/warnings/version-mismatch")
2901429014
);
2901529015
})();
2901629016
("function" === typeof Map &&
@@ -29047,10 +29047,10 @@ __DEV__ &&
2904729047
!(function () {
2904829048
var internals = {
2904929049
bundleType: 1,
29050-
version: "19.2.0-native-fb-4f34cc4a-20250724",
29050+
version: "19.2.0-native-fb-448f781a-20250724",
2905129051
rendererPackageName: "react-dom",
2905229052
currentDispatcherRef: ReactSharedInternals,
29053-
reconcilerVersion: "19.2.0-native-fb-4f34cc4a-20250724"
29053+
reconcilerVersion: "19.2.0-native-fb-448f781a-20250724"
2905429054
};
2905529055
internals.overrideHookState = overrideHookState;
2905629056
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -29188,5 +29188,5 @@ __DEV__ &&
2918829188
listenToAllSupportedEvents(container);
2918929189
return new ReactDOMHydrationRoot(initialChildren);
2919029190
};
29191-
exports.version = "19.2.0-native-fb-4f34cc4a-20250724";
29191+
exports.version = "19.2.0-native-fb-448f781a-20250724";
2919229192
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<987465422a3c8669ee3e87c5ee069431>>
10+
* @generated SignedSource<<5b88a0cd12eb11eefd81fd1a52504184>>
1111
*/
1212

1313
/*
@@ -17123,14 +17123,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1712317123
};
1712417124
var isomorphicReactPackageVersion$jscomp$inline_2004 = React.version;
1712517125
if (
17126-
"19.2.0-native-fb-4f34cc4a-20250724" !==
17126+
"19.2.0-native-fb-448f781a-20250724" !==
1712717127
isomorphicReactPackageVersion$jscomp$inline_2004
1712817128
)
1712917129
throw Error(
1713017130
formatProdErrorMessage(
1713117131
527,
1713217132
isomorphicReactPackageVersion$jscomp$inline_2004,
17133-
"19.2.0-native-fb-4f34cc4a-20250724"
17133+
"19.2.0-native-fb-448f781a-20250724"
1713417134
)
1713517135
);
1713617136
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17152,10 +17152,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1715217152
};
1715317153
var internals$jscomp$inline_2523 = {
1715417154
bundleType: 0,
17155-
version: "19.2.0-native-fb-4f34cc4a-20250724",
17155+
version: "19.2.0-native-fb-448f781a-20250724",
1715617156
rendererPackageName: "react-dom",
1715717157
currentDispatcherRef: ReactSharedInternals,
17158-
reconcilerVersion: "19.2.0-native-fb-4f34cc4a-20250724"
17158+
reconcilerVersion: "19.2.0-native-fb-448f781a-20250724"
1715917159
};
1716017160
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1716117161
var hook$jscomp$inline_2524 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17253,4 +17253,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1725317253
listenToAllSupportedEvents(container);
1725417254
return new ReactDOMHydrationRoot(initialChildren);
1725517255
};
17256-
exports.version = "19.2.0-native-fb-4f34cc4a-20250724";
17256+
exports.version = "19.2.0-native-fb-448f781a-20250724";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<201ce386f08a0993745350b476773407>>
10+
* @generated SignedSource<<03423d1b11b577cbb43391487e0aaee8>>
1111
*/
1212

1313
/*
@@ -19081,14 +19081,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1908119081
};
1908219082
var isomorphicReactPackageVersion$jscomp$inline_2244 = React.version;
1908319083
if (
19084-
"19.2.0-native-fb-4f34cc4a-20250724" !==
19084+
"19.2.0-native-fb-448f781a-20250724" !==
1908519085
isomorphicReactPackageVersion$jscomp$inline_2244
1908619086
)
1908719087
throw Error(
1908819088
formatProdErrorMessage(
1908919089
527,
1909019090
isomorphicReactPackageVersion$jscomp$inline_2244,
19091-
"19.2.0-native-fb-4f34cc4a-20250724"
19091+
"19.2.0-native-fb-448f781a-20250724"
1909219092
)
1909319093
);
1909419094
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19110,10 +19110,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1911019110
};
1911119111
var internals$jscomp$inline_2251 = {
1911219112
bundleType: 0,
19113-
version: "19.2.0-native-fb-4f34cc4a-20250724",
19113+
version: "19.2.0-native-fb-448f781a-20250724",
1911419114
rendererPackageName: "react-dom",
1911519115
currentDispatcherRef: ReactSharedInternals,
19116-
reconcilerVersion: "19.2.0-native-fb-4f34cc4a-20250724",
19116+
reconcilerVersion: "19.2.0-native-fb-448f781a-20250724",
1911719117
getLaneLabelMap: function () {
1911819118
for (
1911919119
var map = new Map(), lane = 1, index$319 = 0;
@@ -19226,4 +19226,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1922619226
listenToAllSupportedEvents(container);
1922719227
return new ReactDOMHydrationRoot(initialChildren);
1922819228
};
19229-
exports.version = "19.2.0-native-fb-4f34cc4a-20250724";
19229+
exports.version = "19.2.0-native-fb-448f781a-20250724";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<b0fdfdd86e3539ba2889617dd8b950f4>>
10+
* @generated SignedSource<<17a3d103fc300bd7fed84e8ffb19acef>>
1111
*/
1212

1313
/*
@@ -29062,11 +29062,11 @@ __DEV__ &&
2906229062
};
2906329063
(function () {
2906429064
var isomorphicReactPackageVersion = React.version;
29065-
if ("19.2.0-native-fb-4f34cc4a-20250724" !== isomorphicReactPackageVersion)
29065+
if ("19.2.0-native-fb-448f781a-20250724" !== isomorphicReactPackageVersion)
2906629066
throw Error(
2906729067
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2906829068
(isomorphicReactPackageVersion +
29069-
"\n - react-dom: 19.2.0-native-fb-4f34cc4a-20250724\nLearn more: https://react.dev/warnings/version-mismatch")
29069+
"\n - react-dom: 19.2.0-native-fb-448f781a-20250724\nLearn more: https://react.dev/warnings/version-mismatch")
2907029070
);
2907129071
})();
2907229072
("function" === typeof Map &&
@@ -29103,10 +29103,10 @@ __DEV__ &&
2910329103
!(function () {
2910429104
var internals = {
2910529105
bundleType: 1,
29106-
version: "19.2.0-native-fb-4f34cc4a-20250724",
29106+
version: "19.2.0-native-fb-448f781a-20250724",
2910729107
rendererPackageName: "react-dom",
2910829108
currentDispatcherRef: ReactSharedInternals,
29109-
reconcilerVersion: "19.2.0-native-fb-4f34cc4a-20250724"
29109+
reconcilerVersion: "19.2.0-native-fb-448f781a-20250724"
2911029110
};
2911129111
internals.overrideHookState = overrideHookState;
2911229112
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -29560,7 +29560,7 @@ __DEV__ &&
2956029560
exports.useFormStatus = function () {
2956129561
return resolveDispatcher().useHostTransitionStatus();
2956229562
};
29563-
exports.version = "19.2.0-native-fb-4f34cc4a-20250724";
29563+
exports.version = "19.2.0-native-fb-448f781a-20250724";
2956429564
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2956529565
"function" ===
2956629566
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<5b0baaab13ef01e3b3b1c97ddfb33b35>>
10+
* @generated SignedSource<<e9e62ae8784af0eaa1197f1139a512d2>>
1111
*/
1212

1313
/*
@@ -17134,14 +17134,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1713417134
};
1713517135
var isomorphicReactPackageVersion$jscomp$inline_2005 = React.version;
1713617136
if (
17137-
"19.2.0-native-fb-4f34cc4a-20250724" !==
17137+
"19.2.0-native-fb-448f781a-20250724" !==
1713817138
isomorphicReactPackageVersion$jscomp$inline_2005
1713917139
)
1714017140
throw Error(
1714117141
formatProdErrorMessage(
1714217142
527,
1714317143
isomorphicReactPackageVersion$jscomp$inline_2005,
17144-
"19.2.0-native-fb-4f34cc4a-20250724"
17144+
"19.2.0-native-fb-448f781a-20250724"
1714517145
)
1714617146
);
1714717147
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17163,10 +17163,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1716317163
};
1716417164
var internals$jscomp$inline_2526 = {
1716517165
bundleType: 0,
17166-
version: "19.2.0-native-fb-4f34cc4a-20250724",
17166+
version: "19.2.0-native-fb-448f781a-20250724",
1716717167
rendererPackageName: "react-dom",
1716817168
currentDispatcherRef: ReactSharedInternals,
17169-
reconcilerVersion: "19.2.0-native-fb-4f34cc4a-20250724"
17169+
reconcilerVersion: "19.2.0-native-fb-448f781a-20250724"
1717017170
};
1717117171
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1717217172
var hook$jscomp$inline_2527 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17417,4 +17417,4 @@ exports.useFormState = function (action, initialState, permalink) {
1741717417
exports.useFormStatus = function () {
1741817418
return ReactSharedInternals.H.useHostTransitionStatus();
1741917419
};
17420-
exports.version = "19.2.0-native-fb-4f34cc4a-20250724";
17420+
exports.version = "19.2.0-native-fb-448f781a-20250724";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-profiling.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<0efa130b0c81e8a43c1bbaba338e429b>>
10+
* @generated SignedSource<<66c2e0a76913fa379b034c165061160a>>
1111
*/
1212

1313
/*
@@ -19096,14 +19096,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1909619096
};
1909719097
var isomorphicReactPackageVersion$jscomp$inline_2245 = React.version;
1909819098
if (
19099-
"19.2.0-native-fb-4f34cc4a-20250724" !==
19099+
"19.2.0-native-fb-448f781a-20250724" !==
1910019100
isomorphicReactPackageVersion$jscomp$inline_2245
1910119101
)
1910219102
throw Error(
1910319103
formatProdErrorMessage(
1910419104
527,
1910519105
isomorphicReactPackageVersion$jscomp$inline_2245,
19106-
"19.2.0-native-fb-4f34cc4a-20250724"
19106+
"19.2.0-native-fb-448f781a-20250724"
1910719107
)
1910819108
);
1910919109
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19125,10 +19125,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1912519125
};
1912619126
var internals$jscomp$inline_2252 = {
1912719127
bundleType: 0,
19128-
version: "19.2.0-native-fb-4f34cc4a-20250724",
19128+
version: "19.2.0-native-fb-448f781a-20250724",
1912919129
rendererPackageName: "react-dom",
1913019130
currentDispatcherRef: ReactSharedInternals,
19131-
reconcilerVersion: "19.2.0-native-fb-4f34cc4a-20250724",
19131+
reconcilerVersion: "19.2.0-native-fb-448f781a-20250724",
1913219132
getLaneLabelMap: function () {
1913319133
for (
1913419134
var map = new Map(), lane = 1, index$319 = 0;
@@ -19394,7 +19394,7 @@ exports.useFormState = function (action, initialState, permalink) {
1939419394
exports.useFormStatus = function () {
1939519395
return ReactSharedInternals.H.useHostTransitionStatus();
1939619396
};
19397-
exports.version = "19.2.0-native-fb-4f34cc4a-20250724";
19397+
exports.version = "19.2.0-native-fb-448f781a-20250724";
1939819398
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1939919399
"function" ===
1940019400
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)