[compiler] Enable additional lints by default (#33752)

Enable more validations to help catch bad patterns, but only in the
linter. These rules are already enabled by default in the compiler _if_
violations could produce unsafe output.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33752).
* #33981
* #33777
* #33767
* #33765
* #33760
* #33759
* #33758
* #33751
* __->__ #33752
* #33753

DiffTrain build for [0d39496](0d39496)

Author: josephsavona

compiled/eslint-plugin-react-hooks/index.js

@@ -30156,7 +30156,7 @@ const EnvironmentConfigSchema = zod.z.object({
     validateHooksUsage: zod.z.boolean().default(true),
     validateRefAccessDuringRender: zod.z.boolean().default(true),
     validateNoSetStateInRender: zod.z.boolean().default(true),
-    validateNoSetStateInPassiveEffects: zod.z.boolean().default(false),
+    validateNoSetStateInEffects: zod.z.boolean().default(false),
     validateNoJSXInTryStatements: zod.z.boolean().default(false),
     validateStaticComponents: zod.z.boolean().default(false),
     validateMemoizedEffectDependencies: zod.z.boolean().default(false),
@@ -48864,7 +48864,7 @@ function emitArrayInstr(elements, env) {
     return arrayInstr;
 }
 
-function validateNoSetStateInPassiveEffects(fn) {
+function validateNoSetStateInEffects(fn) {
     const setStateFunctions = new Map();
     const errors = new CompilerError();
     for (const [, block] of fn.body.blocks) {
@@ -48898,7 +48898,9 @@ function validateNoSetStateInPassiveEffects(fn) {
                     const callee = instr.value.kind === 'MethodCall'
                         ? instr.value.receiver
                         : instr.value.callee;
-                    if (isUseEffectHookType(callee.identifier)) {
+                    if (isUseEffectHookType(callee.identifier) ||
+                        isUseLayoutEffectHookType(callee.identifier) ||
+                        isUseInsertionEffectHookType(callee.identifier)) {
                         const arg = instr.value.args[0];
                         if (arg !== undefined && arg.kind === 'Identifier') {
                             const setState = setStateFunctions.get(arg.identifier.id);
@@ -50118,8 +50120,8 @@ function runWithEnvironment(func, env) {
         if (env.config.validateNoSetStateInRender) {
             validateNoSetStateInRender(hir).unwrap();
         }
-        if (env.config.validateNoSetStateInPassiveEffects) {
-            env.logErrors(validateNoSetStateInPassiveEffects(hir));
+        if (env.config.validateNoSetStateInEffects) {
+            env.logErrors(validateNoSetStateInEffects(hir));
         }
         if (env.config.validateNoJSXInTryStatements) {
             env.logErrors(validateNoJSXInTryStatement(hir));
@@ -51947,6 +51949,12 @@ const COMPILER_OPTIONS = {
     flowSuppressions: false,
     environment: validateEnvironmentConfig({
         validateRefAccessDuringRender: false,
+        validateNoSetStateInRender: true,
+        validateNoSetStateInEffects: true,
+        validateNoJSXInTryStatements: true,
+        validateNoImpureFunctionsInRender: true,
+        validateStaticComponents: true,
+        validateNoFreezingKnownMutableFunctions: true,
     }),
 };
 const rule$1 = {

compiled/facebook-www/REVISION

@@ -1 +1 @@
-448f781a52d62042341d2411d1352d705ce2cbfe
+0d39496eab710b5a3efc07d34c0db3f2475c04f8

compiled/facebook-www/REVISION_TRANSFORMS

@@ -1 +1 @@
-448f781a52d62042341d2411d1352d705ce2cbfe
+0d39496eab710b5a3efc07d34c0db3f2475c04f8

compiled/facebook-www/React-dev.classic.js

@@ -1434,7 +1434,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.2.0-www-classic-448f781a-20250724";
+    exports.version = "19.2.0-www-classic-0d39496e-20250724";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

@@ -1434,7 +1434,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.2.0-www-modern-448f781a-20250724";
+    exports.version = "19.2.0-www-modern-0d39496e-20250724";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

@@ -610,4 +610,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-classic-448f781a-20250724";
+exports.version = "19.2.0-www-classic-0d39496e-20250724";

compiled/facebook-www/React-prod.modern.js

@@ -610,4 +610,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-modern-448f781a-20250724";
+exports.version = "19.2.0-www-modern-0d39496e-20250724";

compiled/facebook-www/React-profiling.classic.js

@@ -614,7 +614,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-classic-448f781a-20250724";
+exports.version = "19.2.0-www-classic-0d39496e-20250724";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

@@ -614,7 +614,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-modern-448f781a-20250724";
+exports.version = "19.2.0-www-modern-0d39496e-20250724";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

@@ -19299,10 +19299,10 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.2.0-www-classic-448f781a-20250724",
+        version: "19.2.0-www-classic-0d39496e-20250724",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.2.0-www-classic-448f781a-20250724"
+        reconcilerVersion: "19.2.0-www-classic-0d39496e-20250724"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19336,7 +19336,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.2.0-www-classic-448f781a-20250724";
+    exports.version = "19.2.0-www-classic-0d39496e-20250724";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&