feat(python): use datetime.fromisoformat() for datetime values in wire tests #10840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs: Slack thread from @tjb9dc
Updates the Python wire test generator to format datetime values using
datetime.fromisoformat()instead of passing them as plain strings.Before:
datetime="2024-07-01T15:30:00+00:00"After:
datetime=datetime.datetime.fromisoformat("2024-07-01T15:30:00+00:00")Changes Made
import datetimeto generated wire test filesgetPrimitiveType()helper to unwrap optional/nullable types and extract the underlying primitive typeformatValue()andjsonToPython()to accept type reference informationDATE_TIME, formats asdatetime.datetime.fromisoformat("...")DATE, formats asdatetime.date.fromisoformat("...")buildPathParameters,buildQueryParameters,buildHeaders, andbuildRequestBodyto pass type information from the dynamic IRTesting
Human Review Checklist
Link to Devin run: https://app.devin.ai/sessions/6f4e456806ef4489adbf5e24aa2e449f
Requested by: @tjb9dc