avoid async call if not needed

marcofranzen99 · yaira2 · commit 11b054b83d94 · 2025-08-10T16:09:55.000-04:00
diff --git a/src/Files.App/Helpers/Win32/Win32Helper.Storage.cs b/src/Files.App/Helpers/Win32/Win32Helper.Storage.cs
@@ -166,7 +166,13 @@ public static Task StartSTATask(Action action)
 		public static async Task<string?> GetFileAssociationAsync(string filename, bool checkDesktopFirst = false)
 		{
 			if (checkDesktopFirst)
-				return GetDesktopFileAssociation(filename) ?? (await GetUwpFileAssociations(filename)).FirstOrDefault();
+			{
+				var desktopAssociation = GetDesktopFileAssociation(filename);
+				if (desktopAssociation is not null)
+					return desktopAssociation;
+
+				return (await GetUwpFileAssociations(filename)).FirstOrDefault();
+			}
 
 			return (await GetUwpFileAssociations(filename)).FirstOrDefault() ?? GetDesktopFileAssociation(filename);
 		}

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,13 @@ public static Task StartSTATask(Action action)`
`166`	`166`	`public static async Task<string?> GetFileAssociationAsync(string filename, bool checkDesktopFirst = false)`
`167`	`167`	`{`
`168`	`168`	`if (checkDesktopFirst)`
`169`		`- return GetDesktopFileAssociation(filename) ?? (await GetUwpFileAssociations(filename)).FirstOrDefault();`
	`169`	`+ {`
	`170`	`+ var desktopAssociation = GetDesktopFileAssociation(filename);`
	`171`	`+ if (desktopAssociation is not null)`
	`172`	`+ return desktopAssociation;`
	`173`	`+`
	`174`	`+ return (await GetUwpFileAssociations(filename)).FirstOrDefault();`
	`175`	`+ }`
`170`	`176`
`171`	`177`	`return (await GetUwpFileAssociations(filename)).FirstOrDefault() ?? GetDesktopFileAssociation(filename);`
`172`	`178`	`}`