-
Notifications
You must be signed in to change notification settings - Fork 38
R-base 4.1: Patch ATSFont calls to CGFont calls, update gcc11 to gcc12 #1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Built successfully on Sonoma 14.2.1 / Xcode 15.1 without the update to gcc12, which currently does not build on Sonoma (not sure about Ventura with Xcode 15). |
|
R packages that use gccXX hardcode the version that R-base was built against. Which is why you see lines like this:
If we update r-base41 to gcc12, then we have update all relevant cran-XXX-r41 packages to use gcc12 (apart from gccXX availability issues across macOS versions). |
|
Will regress to gcc11-shlibs |
|
pushed commits to regress to gcc11 compiler and bumped revision number. |
|
This patch looks like upstream's https://bugs.r-project.org/show_bug.cgi?id=18426 (in which case it's obviously a Good Solution:) so we should cite it as such in the .info (might be cleaner to have that attachment literally as a PatchFile2 instead of merged into the main PatchFile). |
|
I had trouble applying it as a separate patch and thus combined it. I can try to separate them out as separate patches if the consensus is that is "cleaner". |
|
Doesn't really matter whether it is a seperate .patch or not, whatever is easier. But if that's the origin of the patch, definitely need to document that fact in the .info. |
|
Will update the implementation description. |
…nto sth-r-base
… into sth-r-base
…reference to PCRE1 which is not part of this version build.
|
Added comment to BuildDesc tag and removed references to PCRE1 which is not used for R version 4.1 |
R-base4.1 does not compile on MacOS 13. This OS release removed the deprecated ATSFont calls for the newer CGFont calls. This replaces the calls with the corresponding new API. Also updated the link to gcc12-shlibs from gcc11-shlibs.