Skip to content

Commit 9e3bda1

Browse files
authored
Update firebase-admin dependency to allow minor revisions (#424)
* Update admin dependency to allow minor updates * Run formatter * Update integration test dependencies
1 parent ea61f78 commit 9e3bda1

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

integration_test/functions/src/index.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,10 @@ export const integrationTests: any = functions
5353
.https.onRequest((req: Request, resp: Response) => {
5454
// We take the base url for our https call (cloudfunctions.net, txckloud.net, etc) from the request
5555
// so that it changes with the environment that the tests are run in
56-
const baseUrl = req.hostname.split('.').slice(1).join('.');
56+
const baseUrl = req.hostname
57+
.split('.')
58+
.slice(1)
59+
.join('.');
5760
let pubsub: any = require('@google-cloud/pubsub')();
5861
const testId = admin
5962
.database()

integration_test/package.node6.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"@google-cloud/pubsub": "~0.19.0",
99
"@types/google-cloud__pubsub": "^0.18.0",
1010
"@types/lodash": "~4.14.41",
11-
"firebase-admin": "~7.0.0",
11+
"firebase-admin": "^7.0.0",
1212
"firebase-functions": "./firebase-functions.tgz",
1313
"lodash": "~4.17.2"
1414
},

integration_test/package.node8.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"@google-cloud/pubsub": "~0.19.0",
99
"@types/google-cloud__pubsub": "^0.18.0",
1010
"@types/lodash": "~4.14.41",
11-
"firebase-admin": "~7.0.0",
11+
"firebase-admin": "^7.0.0",
1212
"firebase-functions": "./firebase-functions.tgz",
1313
"lodash": "~4.17.2"
1414
},

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"@types/sinon": "^1.16.29",
4141
"chai": "^3.5.0",
4242
"chai-as-promised": "^5.2.0",
43-
"firebase-admin": "~7.0.0",
43+
"firebase-admin": "^7.0.0",
4444
"istanbul": "^0.4.2",
4545
"mocha": "^5.2.0",
4646
"mock-require": "^2.0.1",
@@ -51,7 +51,7 @@
5151
"typescript": "~3.1.0"
5252
},
5353
"peerDependencies": {
54-
"firebase-admin": "~7.0.0"
54+
"firebase-admin": "^7.0.0"
5555
},
5656
"dependencies": {
5757
"@types/cors": "^2.8.1",

src/providers/https.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ import { HttpsFunction, optsToTrigger, Runnable } from '../cloud-functions';
2929
import { DeploymentOptions } from '../function-builder';
3030

3131
/**
32-
*
33-
*
32+
*
33+
*
3434
*/
3535
export interface Request extends express.Request {
3636
rawBody: Buffer;

0 commit comments

Comments
 (0)