chore: apply Biome formatting to match new style

- Apply Biome's opinionated formatting across the codebase
- Updates include:
  - Closing parentheses moved to same line for arrow functions
  - Multi-parameter constructors formatted on separate lines
  - Unnecessary object key quotes removed
  - Better string concatenation indentation
- These changes improve code readability and consistency

Author: taeold

biome.json

@@ -1,12 +1,12 @@
 {
   "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
-  "vcs": { 
-    "enabled": true, 
-    "clientKind": "git", 
-    "useIgnoreFile": true 
+  "vcs": {
+    "enabled": true,
+    "clientKind": "git",
+    "useIgnoreFile": true
   },
-  "files": { 
-    "ignoreUnknown": false, 
+  "files": {
+    "ignoreUnknown": false,
     "ignore": [
       "**/lib",
       "**/node_modules",
@@ -79,10 +79,19 @@
   },
   "javascript": {
     "formatter": {
-      "quoteStyle": "single",
+      "quoteStyle": "double",
+      "quoteProperties": "preserve",
       "semicolons": "always",
-      "trailingCommas": "all",
-      "arrowParentheses": "always"
+      "trailingCommas": "es5",
+      "arrowParentheses": "always",
+      "bracketSpacing": true,
+      "bracketSameLine": false
+    }
+  },
+  "json": {
+    "formatter": {
+      "indentStyle": "space",
+      "indentWidth": 2
     }
   }
-}
+}

integration_test/functions/src/index.ts

@@ -9,7 +9,7 @@ import fetch from "node-fetch";
 import * as v1 from "./v1";
 import * as v2 from "./v2";
 const getNumTests = (m: object): number => {
-  return Object.keys(m).filter((k) => ({}.hasOwnProperty.call(m[k], "__endpoint"))).length;
+  return Object.keys(m).filter((k) => ({}).hasOwnProperty.call(m[k], "__endpoint")).length;
 };
 const numTests = getNumTests(v1) + getNumTests(v2);
 export { v1, v2 };
@@ -132,9 +132,14 @@ async function updateRemoteConfig(testId: string, accessToken: string): Promise<
 function v1Tests(testId: string, accessToken: string): Array<Promise<unknown>> {
   return [
     // A database write to trigger the Firebase Realtime Database tests.
-    admin.database().ref(`dbTests/${testId}/start`).set({ ".sv": "timestamp" }),
+    admin
+      .database()
+      .ref(`dbTests/${testId}/start`)
+      .set({ ".sv": "timestamp" }),
     // A Pub/Sub publish to trigger the Cloud Pub/Sub tests.
-    new PubSub().topic("pubsubTests").publish(Buffer.from(JSON.stringify({ testId }))),
+    new PubSub()
+      .topic("pubsubTests")
+      .publish(Buffer.from(JSON.stringify({ testId }))),
     // A user creation to trigger the Firebase Auth user creation tests.
     admin
       .auth()
@@ -148,7 +153,11 @@ function v1Tests(testId: string, accessToken: string): Array<Promise<unknown>> {
         await admin.auth().deleteUser(userRecord.uid);
       }),
     // A firestore write to trigger the Cloud Firestore tests.
-    admin.firestore().collection("tests").doc(testId).set({ test: testId }),
+    admin
+      .firestore()
+      .collection("tests")
+      .doc(testId)
+      .set({ test: testId }),
     // Invoke a callable HTTPS trigger.
     // TODO: Temporarily disable - doesn't work unless running on projects w/ permission to create public functions.
     // callHttpsTrigger("v1-callableTests", { foo: "bar", testId }),

integration_test/functions/src/v1/auth-tests.ts

@@ -13,14 +13,12 @@ export const createUserTests: any = functions
 
     return new TestSuite<UserMetadata>("auth user onCreate")
       .it("should have a project as resource", (user, context) =>
-        expectEq(context.resource.name, `projects/${process.env.GCLOUD_PROJECT}`)
-      )
+        expectEq(context.resource.name, `projects/${process.env.GCLOUD_PROJECT}`))
 
       .it("should not have a path", (user, context) => expectEq((context as any).path, undefined))
 
       .it("should have the correct eventType", (user, context) =>
-        expectEq(context.eventType, "google.firebase.auth.user.create")
-      )
+        expectEq(context.eventType, "google.firebase.auth.user.create"))
 
       .it("should have an eventId", (user, context) => context.eventId)
 
@@ -44,14 +42,12 @@ export const deleteUserTests: any = functions
 
     return new TestSuite<UserMetadata>("auth user onDelete")
       .it("should have a project as resource", (user, context) =>
-        expectEq(context.resource.name, `projects/${process.env.GCLOUD_PROJECT}`)
-      )
+        expectEq(context.resource.name, `projects/${process.env.GCLOUD_PROJECT}`))
 
       .it("should not have a path", (user, context) => expectEq((context as any).path, undefined))
 
       .it("should have the correct eventType", (user, context) =>
-        expectEq(context.eventType, "google.firebase.auth.user.delete")
-      )
+        expectEq(context.eventType, "google.firebase.auth.user.delete"))
 
       .it("should have an eventId", (user, context) => context.eventId)
 

integration_test/functions/src/v1/database-tests.ts

@@ -25,8 +25,7 @@ export const databaseTests: any = functions
         change.after.ref.parent
           .child("adminOnly")
           .update({ allowed: 1 })
-          .then(() => true)
-      )
+          .then(() => true))
 
       .it("should have a correct ref url", (change) => {
         const url = change.after.ref.toString();
@@ -50,24 +49,20 @@ export const databaseTests: any = functions
           new RegExp(
             `^projects/_/instances/${process.env.GCLOUD_PROJECT}(-default-rtdb)*/refs/dbTests/${context.params.testId}/start$`
           )
-        )
-      )
+        ))
 
       .it("should not include path", (change, context) =>
-        expectEq((context as any).path, undefined)
-      )
+        expectEq((context as any).path, undefined))
 
       .it("should have the right eventType", (change, context) =>
-        expectEq(context.eventType, "google.firebase.database.ref.write")
-      )
+        expectEq(context.eventType, "google.firebase.database.ref.write"))
 
       .it("should have eventId", (change, context) => context.eventId)
 
       .it("should have timestamp", (change, context) => context.timestamp)
 
       .it("should not have action", (change, context) =>
-        expectEq((context as any).action, undefined)
-      )
+        expectEq((context as any).action, undefined))
 
       .it("should have admin authType", (change, context) => expectEq(context.authType, "ADMIN"))
 

integration_test/functions/src/v1/firestore-tests.ts

@@ -18,27 +18,23 @@ export const firestoreTests: any = functions
       .it("should not have event.app", (snap, context) => !(context as any).app)
 
       .it("should give refs write access", (snap) =>
-        snap.ref.set({ allowed: 1 }, { merge: true }).then(() => true)
-      )
+        snap.ref.set({ allowed: 1 }, { merge: true }).then(() => true))
 
       .it("should have well-formatted resource", (snap, context) =>
         expectEq(
           context.resource.name,
           `projects/${process.env.GCLOUD_PROJECT}/databases/(default)/documents/tests/${context.params.documentId}`
-        )
-      )
+        ))
 
       .it("should have the right eventType", (snap, context) =>
-        expectEq(context.eventType, "google.firestore.document.create")
-      )
+        expectEq(context.eventType, "google.firestore.document.create"))
 
       .it("should have eventId", (snap, context) => context.eventId)
 
       .it("should have timestamp", (snap, context) => context.timestamp)
 
       .it("should have the correct data", (snap, context) =>
-        expectDeepEq(snap.data(), { test: context.params.documentId })
-      )
+        expectDeepEq(snap.data(), { test: context.params.documentId }))
 
       .run(c.params[testIdFieldName], s, c);
   });

integration_test/functions/src/v1/pubsub-tests.ts

@@ -19,16 +19,16 @@ export const pubsubTests: any = functions
 
     return new TestSuite<PubsubMessage>("pubsub onPublish")
       .it("should have a topic as resource", (message, context) =>
-        expectEq(context.resource.name, `projects/${process.env.GCLOUD_PROJECT}/topics/pubsubTests`)
-      )
+        expectEq(
+          context.resource.name,
+          `projects/${process.env.GCLOUD_PROJECT}/topics/pubsubTests`
+        ))
 
       .it("should not have a path", (message, context) =>
-        expectEq((context as any).path, undefined)
-      )
+        expectEq((context as any).path, undefined))
 
       .it("should have the correct eventType", (message, context) =>
-        expectEq(context.eventType, "google.pubsub.topic.publish")
-      )
+        expectEq(context.eventType, "google.pubsub.topic.publish"))
 
       .it("should have an eventId", (message, context) => context.eventId)
 
@@ -37,8 +37,7 @@ export const pubsubTests: any = functions
       .it("should not have auth", (message, context) => expectEq((context as any).auth, undefined))
 
       .it("should not have action", (message, context) =>
-        expectEq((context as any).action, undefined)
-      )
+        expectEq((context as any).action, undefined))
 
       .it("should have pubsub data", (message) => {
         const decoded = new Buffer(message.data, "base64").toString();
@@ -47,8 +46,7 @@ export const pubsubTests: any = functions
       })
 
       .it("should decode JSON payloads with the json helper", (message) =>
-        evaluate(message.json.hasOwnProperty("testId"), message.json)
-      )
+        evaluate(message.json.hasOwnProperty("testId"), message.json))
 
       .run(testId, m, c);
   });

integration_test/functions/src/v1/remoteConfig-tests.ts

@@ -6,12 +6,10 @@ import TemplateVersion = functions.remoteConfig.TemplateVersion;
 export const remoteConfigTests: any = functions.region(REGION).remoteConfig.onUpdate((v, c) => {
   return new TestSuite<TemplateVersion>("remoteConfig onUpdate")
     .it("should have a project as resource", (version, context) =>
-      expectEq(context.resource.name, `projects/${process.env.GCLOUD_PROJECT}`)
-    )
+      expectEq(context.resource.name, `projects/${process.env.GCLOUD_PROJECT}`))
 
     .it("should have the correct eventType", (version, context) =>
-      expectEq(context.eventType, "google.firebase.remoteconfig.update")
-    )
+      expectEq(context.eventType, "google.firebase.remoteconfig.update"))
 
     .it("should have an eventId", (version, context) => context.eventId)
 

integration_test/functions/src/v1/storage-tests.ts

@@ -17,8 +17,7 @@ export const storageTests: any = functions
       .it("should not have event.app", (data, context) => !(context as any).app)
 
       .it("should have the right eventType", (snap, context) =>
-        expectEq(context.eventType, "google.storage.object.finalize")
-      )
+        expectEq(context.eventType, "google.storage.object.finalize"))
 
       .it("should have eventId", (snap, context) => context.eventId)
 

integration_test/functions/src/v1/testLab-tests.ts

@@ -14,8 +14,7 @@ export const testLabTests: any = functions
       .it("should have eventId", (snap, context) => context.eventId)
 
       .it("should have right eventType", (_, context) =>
-        expectEq(context.eventType, "google.testing.testMatrix.complete")
-      )
+        expectEq(context.eventType, "google.testing.testMatrix.complete"))
 
       .it("should be in state 'INVALID'", (matrix) => expectEq(matrix.state, "INVALID"))
 

package.json

@@ -259,7 +259,7 @@
     "build:watch": "npm run build -- -w",
     "format": "biome format --write .",
     "format:check": "biome format .",
-    "lint": "biome check .",
+    "lint": "biome lint .",
     "lint:fix": "biome check --write .",
     "test": "mocha --file ./mocha/setup.ts \"spec/**/*.spec.ts\"",
     "test:bin": "./scripts/bin-test/run.sh",