From 358815e18e0f5517a62f63bd346692f4f196a9fa Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Mon, 22 Dec 2025 18:35:21 -0800 Subject: [PATCH 01/20] [Infra] Update danger tool version --- Gemfile | 2 +- Gemfile.lock | 64 ++++++++++++++++++++-------------------------------- 2 files changed, 25 insertions(+), 41 deletions(-) diff --git a/Gemfile b/Gemfile index cc267b2e746..224834d51d0 100644 --- a/Gemfile +++ b/Gemfile @@ -14,4 +14,4 @@ source 'https://rubygems.org' gem 'cocoapods', '1.16.2' gem 'cocoapods-generate', '2.2.5' -gem 'danger', '8.4.5' +gem 'danger', '9.5.3' diff --git a/Gemfile.lock b/Gemfile.lock index c4e166dd671..d9d11fa7972 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -77,48 +77,31 @@ GEM connection_pool (2.4.1) cork (0.3.0) colored2 (~> 3.1) - danger (8.4.5) + danger (9.5.3) + base64 (~> 0.2) claide (~> 1.0) claide-plugins (>= 0.9.2) - colored2 (~> 3.1) + colored2 (>= 3.1, < 5) cork (~> 0.1) - faraday (>= 0.9.0, < 2.0) + faraday (>= 0.9.0, < 3.0) faraday-http-cache (~> 2.0) - git (~> 1.7) - kramdown (~> 2.3) + git (>= 1.13, < 3.0) + kramdown (>= 2.5.1, < 3.0) kramdown-parser-gfm (~> 1.0) - no_proxy_fix - octokit (~> 4.7) - terminal-table (>= 1, < 4) + octokit (>= 4.0) + pstore (~> 0.1) + terminal-table (>= 1, < 5) drb (2.2.1) escape (0.0.4) ethon (0.16.0) ffi (>= 1.15.0) - faraday (1.10.3) - faraday-em_http (~> 1.0) - faraday-em_synchrony (~> 1.0) - faraday-excon (~> 1.1) - faraday-httpclient (~> 1.0) - faraday-multipart (~> 1.0) - faraday-net_http (~> 1.0) - faraday-net_http_persistent (~> 1.0) - faraday-patron (~> 1.0) - faraday-rack (~> 1.0) - faraday-retry (~> 1.0) + faraday (2.8.1) + base64 + faraday-net_http (>= 2.0, < 3.1) ruby2_keywords (>= 0.0.4) - faraday-em_http (1.0.0) - faraday-em_synchrony (1.0.0) - faraday-excon (1.1.0) faraday-http-cache (2.5.1) faraday (>= 0.8) - faraday-httpclient (1.0.1) - faraday-multipart (1.0.4) - multipart-post (~> 2) - faraday-net_http (1.0.2) - faraday-net_http_persistent (1.2.0) - faraday-patron (1.0.0) - faraday-rack (1.0.0) - faraday-retry (1.0.3) + faraday-net_http (3.0.2) ffi (1.17.0) fourflusher (2.3.1) fuzzy_match (2.0.4) @@ -130,40 +113,41 @@ GEM i18n (1.14.6) concurrent-ruby (~> 1.0) json (2.7.5) - kramdown (2.4.0) - rexml + kramdown (2.5.1) + rexml (>= 3.3.9) kramdown-parser-gfm (1.1.0) kramdown (~> 2.0) logger (1.6.1) minitest (5.25.1) molinillo (0.8.0) - multipart-post (2.4.1) mutex_m (0.2.0) nanaimo (0.4.0) nap (1.1.0) netrc (0.11.0) nkf (0.2.0) - no_proxy_fix (0.1.2) - octokit (4.25.1) + octokit (10.0.0) faraday (>= 1, < 3) sawyer (~> 0.9) open4 (1.3.4) + pstore (0.2.0) public_suffix (4.0.7) rchardet (1.8.0) rexml (3.4.2) ruby-macho (2.5.1) ruby2_keywords (0.0.5) - sawyer (0.9.2) + sawyer (0.9.3) addressable (>= 2.3.5) faraday (>= 0.17.3, < 3) securerandom (0.3.1) - terminal-table (3.0.2) - unicode-display_width (>= 1.1.1, < 3) + terminal-table (4.0.0) + unicode-display_width (>= 1.1.1, < 4) typhoeus (1.4.1) ethon (>= 0.9.0) tzinfo (2.0.6) concurrent-ruby (~> 1.0) - unicode-display_width (2.5.0) + unicode-display_width (3.2.0) + unicode-emoji (~> 4.1) + unicode-emoji (4.2.0) xcodeproj (1.27.0) CFPropertyList (>= 2.3.3, < 4.0) atomos (~> 0.1.3) @@ -178,7 +162,7 @@ PLATFORMS DEPENDENCIES cocoapods (= 1.16.2) cocoapods-generate (= 2.2.5) - danger (= 8.4.5) + danger (= 9.5.3) BUNDLED WITH 2.1.4 From d8836d8adcec92a0b30ea39ecf5a90d11f78b330 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Mon, 22 Dec 2025 18:44:38 -0800 Subject: [PATCH 02/20] Test tagging --- FirebaseRemoteConfig/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/FirebaseRemoteConfig/README.md b/FirebaseRemoteConfig/README.md index 909db17fa0f..9c2d7deebf6 100644 --- a/FirebaseRemoteConfig/README.md +++ b/FirebaseRemoteConfig/README.md @@ -6,5 +6,6 @@ Objective-C and Swift. Firebase Remote Config is a cloud service that lets you change the appearance and behavior of your app without requiring users to download an app update. + Please visit [our developer site](https://firebase.google.com/docs/remote-config/) for integration instructions, documentation, support information, and terms of service. From c1b423589bdd9e03a3b2eeea14c2650e46bb40e5 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 07:59:28 -0800 Subject: [PATCH 03/20] Update danger action permissions --- .github/workflows/danger.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index dc3a0fe33b7..d4969e76386 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -9,6 +9,10 @@ concurrency: jobs: danger: runs-on: macos-14 + permissions: + issues: write + pull-requests: write + contents: read # Required to read the Dangerfile steps: - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 From a1a9a712a4c16ad843c22a5935bc8e73dbd93ed9 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 08:17:59 -0800 Subject: [PATCH 04/20] use default GITHUB_TOKEN --- .github/workflows/danger.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index d4969e76386..c521a4e88d1 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -20,5 +20,5 @@ jobs: run: scripts/setup_bundler.sh - name: Danger env: - DANGER_GITHUB_API_TOKEN: ${{ secrets.DangerGitHubAPIToken }} + DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: '[ ! -z $DANGER_GITHUB_API_TOKEN ] && bundle exec danger || echo "Skipping Danger for External Contributor"' From 05ec5dd401f9f747bf5af2e14619f5b14e6044eb Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 08:21:43 -0800 Subject: [PATCH 05/20] Update GitHub api call --- .github/workflows/danger.yml | 2 +- Dangerfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index c521a4e88d1..004647777e7 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -8,7 +8,7 @@ concurrency: jobs: danger: - runs-on: macos-14 + runs-on: macos-15 permissions: issues: write pull-requests: write diff --git a/Dangerfile b/Dangerfile index c2fc33a1947..6f480fef43b 100644 --- a/Dangerfile +++ b/Dangerfile @@ -40,7 +40,7 @@ end def addLabels(label_array) issue_number = github.pr_json["number"] repo_name = "firebase/firebase-ios-sdk" - github.api.add_labels_to_an_issue(repo_name, issue_number, label_array) + github.add_labels(label_array) end # Returns a list of all labels for a given PR. PRs that touch From f0b1ae9d4811da11f515783588775a2b73098cd8 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 08:29:11 -0800 Subject: [PATCH 06/20] pull_request_target --- .github/workflows/danger.yml | 2 +- Dangerfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 004647777e7..55911b0ae7e 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -1,6 +1,6 @@ name: danger -on: [pull_request, workflow_dispatch] +on: [pull_request_target, workflow_dispatch] concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.ref }} diff --git a/Dangerfile b/Dangerfile index 6f480fef43b..c2fc33a1947 100644 --- a/Dangerfile +++ b/Dangerfile @@ -40,7 +40,7 @@ end def addLabels(label_array) issue_number = github.pr_json["number"] repo_name = "firebase/firebase-ios-sdk" - github.add_labels(label_array) + github.api.add_labels_to_an_issue(repo_name, issue_number, label_array) end # Returns a list of all labels for a given PR. PRs that touch From 5881eaacf225261b490a5a9fb113b6cf1e8eacc3 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 08:35:29 -0800 Subject: [PATCH 07/20] touch --- Dangerfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Dangerfile b/Dangerfile index c2fc33a1947..5b9de55e89c 100644 --- a/Dangerfile +++ b/Dangerfile @@ -12,8 +12,8 @@ def didModify(files_array) return false end -# Determine if there are changes in files matching any of the -# path patterns provided. +# Determine if there are changes in files matching any of the path +# patterns provided. def hasChangesIn(paths) path_array = Array(paths) path_array.each do |dir| From 2753a4875bf53d1a7aa90736a9ad24e84fcdbdca Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 08:41:37 -0800 Subject: [PATCH 08/20] update checkout sha --- .github/workflows/danger.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 55911b0ae7e..72023c6a208 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -1,6 +1,9 @@ name: danger -on: [pull_request_target, workflow_dispatch] +on: + pull_request_target: # Change from pull_request to pull_request_target + types: [opened, synchronize, reopened] + workflow_dispatch: concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.ref }} @@ -15,6 +18,8 @@ jobs: contents: read # Required to read the Dangerfile steps: - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 + with: + ref: ${{ github.event.pull_request.head.sha }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Setup Bundler run: scripts/setup_bundler.sh From 2c58f02636836757cd6fd63be4e4e739a4917432 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 08:49:25 -0800 Subject: [PATCH 09/20] restore --- Dangerfile | 4 ++-- FirebaseRemoteConfig/README.md | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Dangerfile b/Dangerfile index 5b9de55e89c..c2fc33a1947 100644 --- a/Dangerfile +++ b/Dangerfile @@ -12,8 +12,8 @@ def didModify(files_array) return false end -# Determine if there are changes in files matching any of the path -# patterns provided. +# Determine if there are changes in files matching any of the +# path patterns provided. def hasChangesIn(paths) path_array = Array(paths) path_array.each do |dir| diff --git a/FirebaseRemoteConfig/README.md b/FirebaseRemoteConfig/README.md index 9c2d7deebf6..909db17fa0f 100644 --- a/FirebaseRemoteConfig/README.md +++ b/FirebaseRemoteConfig/README.md @@ -6,6 +6,5 @@ Objective-C and Swift. Firebase Remote Config is a cloud service that lets you change the appearance and behavior of your app without requiring users to download an app update. - Please visit [our developer site](https://firebase.google.com/docs/remote-config/) for integration instructions, documentation, support information, and terms of service. From 2d9d4addec8009fa368ba563e32b3bade079835d Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 09:15:49 -0800 Subject: [PATCH 10/20] back to safer pull_request --- .github/workflows/danger.yml | 6 ++---- Dangerfile | 6 +++++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 72023c6a208..46a702a5ffd 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -1,7 +1,7 @@ name: danger on: - pull_request_target: # Change from pull_request to pull_request_target + pull_request: types: [opened, synchronize, reopened] workflow_dispatch: @@ -18,12 +18,10 @@ jobs: contents: read # Required to read the Dangerfile steps: - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 - with: - ref: ${{ github.event.pull_request.head.sha }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Setup Bundler run: scripts/setup_bundler.sh - name: Danger env: DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: '[ ! -z $DANGER_GITHUB_API_TOKEN ] && bundle exec danger || echo "Skipping Danger for External Contributor"' + run: bundle exec danger diff --git a/Dangerfile b/Dangerfile index c2fc33a1947..c9fbfc2737d 100644 --- a/Dangerfile +++ b/Dangerfile @@ -40,7 +40,11 @@ end def addLabels(label_array) issue_number = github.pr_json["number"] repo_name = "firebase/firebase-ios-sdk" - github.api.add_labels_to_an_issue(repo_name, issue_number, label_array) + begin + github.api.add_labels_to_an_issue(repo_name, issue_number, label_array) + rescue Octokit::Forbidden + warn "Unable to add labels (Insufficient permissions). This is expected + end end # Returns a list of all labels for a given PR. PRs that touch From 48ee7d2750314907bd01b6f589346156a4110f12 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 09:20:16 -0800 Subject: [PATCH 11/20] ruby syntax --- Dangerfile | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Dangerfile b/Dangerfile index c9fbfc2737d..0f731aba936 100644 --- a/Dangerfile +++ b/Dangerfile @@ -40,11 +40,9 @@ end def addLabels(label_array) issue_number = github.pr_json["number"] repo_name = "firebase/firebase-ios-sdk" - begin - github.api.add_labels_to_an_issue(repo_name, issue_number, label_array) - rescue Octokit::Forbidden + github.api.add_labels_to_an_issue(repo_name, issue_number, label_array) +rescue Octokit::Forbidden warn "Unable to add labels (Insufficient permissions). This is expected - end end # Returns a list of all labels for a given PR. PRs that touch From 2b13e54bd3b34be3c95a78643331e30b4ca329e4 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 09:24:31 -0800 Subject: [PATCH 12/20] ruby arggh --- Dangerfile | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/Dangerfile b/Dangerfile index 0f731aba936..a0b0dfca00d 100644 --- a/Dangerfile +++ b/Dangerfile @@ -40,9 +40,19 @@ end def addLabels(label_array) issue_number = github.pr_json["number"] repo_name = "firebase/firebase-ios-sdk" - github.api.add_labels_to_an_issue(repo_name, issue_number, label_array) -rescue Octokit::Forbidden - warn "Unable to add labels (Insufficient permissions). This is expected + + begin + # Ensure label_array is actually an array, as the API requires it + labels = Array(label_array) + github.api.add_labels_to_an_issue(repo_name, issue_number, labels) + rescue Octokit::Forbidden => e + # This captures the "Must have admin rights" / 403 error + warn "Unable to add labels: #{labels.join(', ')}. " \ + "This usually happens on PRs from external forks where the GITHUB_TOKEN is read-only for security. " \ + "Error details: #{e.message}" + rescue StandardError => e + warn "An unexpected error occurred while adding labels: #{e.message}" + end end # Returns a list of all labels for a given PR. PRs that touch From e7f5284ffdaea034582c12fd6d1773e9839968ad Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 11:56:56 -0800 Subject: [PATCH 13/20] Using new fine-grained token --- .github/workflows/danger.yml | 4 ++-- Dangerfile | 14 +------------- FirebaseRemoteConfig/README.md | 1 + 3 files changed, 4 insertions(+), 15 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 46a702a5ffd..8648e17f33a 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -23,5 +23,5 @@ jobs: run: scripts/setup_bundler.sh - name: Danger env: - DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: bundle exec danger + DANGER_GITHUB_API_TOKEN: ${{ secrets.DANGER_GITHUB_API_TOKEN }} + run: '[ ! -z $DANGER_GITHUB_API_TOKEN ] && bundle exec danger || echo "Skipping Danger for External Contributor"' diff --git a/Dangerfile b/Dangerfile index a0b0dfca00d..c2fc33a1947 100644 --- a/Dangerfile +++ b/Dangerfile @@ -40,19 +40,7 @@ end def addLabels(label_array) issue_number = github.pr_json["number"] repo_name = "firebase/firebase-ios-sdk" - - begin - # Ensure label_array is actually an array, as the API requires it - labels = Array(label_array) - github.api.add_labels_to_an_issue(repo_name, issue_number, labels) - rescue Octokit::Forbidden => e - # This captures the "Must have admin rights" / 403 error - warn "Unable to add labels: #{labels.join(', ')}. " \ - "This usually happens on PRs from external forks where the GITHUB_TOKEN is read-only for security. " \ - "Error details: #{e.message}" - rescue StandardError => e - warn "An unexpected error occurred while adding labels: #{e.message}" - end + github.api.add_labels_to_an_issue(repo_name, issue_number, label_array) end # Returns a list of all labels for a given PR. PRs that touch diff --git a/FirebaseRemoteConfig/README.md b/FirebaseRemoteConfig/README.md index 909db17fa0f..9c2d7deebf6 100644 --- a/FirebaseRemoteConfig/README.md +++ b/FirebaseRemoteConfig/README.md @@ -6,5 +6,6 @@ Objective-C and Swift. Firebase Remote Config is a cloud service that lets you change the appearance and behavior of your app without requiring users to download an app update. + Please visit [our developer site](https://firebase.google.com/docs/remote-config/) for integration instructions, documentation, support information, and terms of service. From 5f1b0a6abce67376764e6f0c95dffcb4f0a89385 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 13:37:24 -0800 Subject: [PATCH 14/20] Another approach --- .github/workflows/danger.yml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 8648e17f33a..87b3f1a054b 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -18,10 +18,19 @@ jobs: contents: read # Required to read the Dangerfile steps: - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 + + - name: Generate GitHub App Token + id: generate-token + uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf #v2.2.1 + with: + app-id: ${{ secrets.DANGER_APP_ID }} + private-key: ${{ secrets.DANGER_APP_PRIVATE_KEY }} + - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Setup Bundler run: scripts/setup_bundler.sh + - name: Danger env: - DANGER_GITHUB_API_TOKEN: ${{ secrets.DANGER_GITHUB_API_TOKEN }} + DANGER_GITHUB_API_TOKEN: ${{ steps.generate-token.outputs.token }} run: '[ ! -z $DANGER_GITHUB_API_TOKEN ] && bundle exec danger || echo "Skipping Danger for External Contributor"' From 7fe10c64bb379985ce5fcdbaff33ee5f257bbc65 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 13:38:56 -0800 Subject: [PATCH 15/20] Trigger another label --- FirebaseStorage/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FirebaseStorage/CHANGELOG.md b/FirebaseStorage/CHANGELOG.md index fca3085cc3b..fc174bea42e 100644 --- a/FirebaseStorage/CHANGELOG.md +++ b/FirebaseStorage/CHANGELOG.md @@ -4,7 +4,7 @@ # 11.13.0 - [fixed] `putFile` now works in App Clips. Similarly to app extensions, background session - configurations are not used in App Clips (#14794). + configurations are not used in App Clips. (#14794) # 11.1.0 - [fixed] Fix a potential data race in Storage initialization. (#13369) From d5287553932d6e12ea92daff3c18443844a8373a Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 13:41:44 -0800 Subject: [PATCH 16/20] indentation --- .github/workflows/danger.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 87b3f1a054b..c44e7c135b6 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -20,11 +20,11 @@ jobs: - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 - name: Generate GitHub App Token - id: generate-token - uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf #v2.2.1 - with: - app-id: ${{ secrets.DANGER_APP_ID }} - private-key: ${{ secrets.DANGER_APP_PRIVATE_KEY }} + id: generate-token + uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf #v2.2.1 + with: + app-id: ${{ secrets.DANGER_APP_ID }} + private-key: ${{ secrets.DANGER_APP_PRIVATE_KEY }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Setup Bundler From ed101dcb1cc7cb848c5c6152daf1f34f480a9c4d Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 13:48:13 -0800 Subject: [PATCH 17/20] Restore trigger files --- FirebaseRemoteConfig/README.md | 1 - FirebaseStorage/CHANGELOG.md | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/FirebaseRemoteConfig/README.md b/FirebaseRemoteConfig/README.md index 9c2d7deebf6..909db17fa0f 100644 --- a/FirebaseRemoteConfig/README.md +++ b/FirebaseRemoteConfig/README.md @@ -6,6 +6,5 @@ Objective-C and Swift. Firebase Remote Config is a cloud service that lets you change the appearance and behavior of your app without requiring users to download an app update. - Please visit [our developer site](https://firebase.google.com/docs/remote-config/) for integration instructions, documentation, support information, and terms of service. diff --git a/FirebaseStorage/CHANGELOG.md b/FirebaseStorage/CHANGELOG.md index fc174bea42e..fca3085cc3b 100644 --- a/FirebaseStorage/CHANGELOG.md +++ b/FirebaseStorage/CHANGELOG.md @@ -4,7 +4,7 @@ # 11.13.0 - [fixed] `putFile` now works in App Clips. Similarly to app extensions, background session - configurations are not used in App Clips. (#14794) + configurations are not used in App Clips (#14794). # 11.1.0 - [fixed] Fix a potential data race in Storage initialization. (#13369) From 0be6765530ca521040ac45be82c422025f16ed78 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 13:49:28 -0800 Subject: [PATCH 18/20] Test changelog trigger --- Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index 224834d51d0..f65d972e637 100644 --- a/Gemfile +++ b/Gemfile @@ -2,7 +2,7 @@ # commit Gemfile and Gemfile.lock. source 'https://rubygems.org' -# To test CocoaPods pre-releases, update to a relevant commit or tag like below +# To test CocoaPods pre-releases, update to a relevant commit or tag like below. # cocoapods-core and xcodeproj may or may not also need tags. For additional # testing, enable the cron jobs with a global search and replace from your # favorite editor. See https://github.com/firebase/firebase-ios-sdk/pull/8498 From 752005aae1e03360c4f072f6b7b1c3aa5e3f86d3 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 15:40:26 -0800 Subject: [PATCH 19/20] Try again --- FirebaseMessaging/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FirebaseMessaging/CHANGELOG.md b/FirebaseMessaging/CHANGELOG.md index f2756c5ce0a..ea3f75e391f 100644 --- a/FirebaseMessaging/CHANGELOG.md +++ b/FirebaseMessaging/CHANGELOG.md @@ -4,7 +4,7 @@ distributions, but will be included from 12.2.0 onwards. (#15159) # 11.14.0 -- [fixed] Fix a potential SQL injection issue. (#14846). +- [fixed] Fix a potential SQL injection issue. (#14846) # 11.9.0 - [fixed] Migrate FCM codebase to new NSKeyedUnarchiver APIs. (#14424). From 25fcd7fca6e08a082ae0d78d888cdea10cfab187 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Tue, 23 Dec 2025 15:45:49 -0800 Subject: [PATCH 20/20] Successfully tagged --- FirebaseMessaging/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FirebaseMessaging/CHANGELOG.md b/FirebaseMessaging/CHANGELOG.md index ea3f75e391f..f2756c5ce0a 100644 --- a/FirebaseMessaging/CHANGELOG.md +++ b/FirebaseMessaging/CHANGELOG.md @@ -4,7 +4,7 @@ distributions, but will be included from 12.2.0 onwards. (#15159) # 11.14.0 -- [fixed] Fix a potential SQL injection issue. (#14846) +- [fixed] Fix a potential SQL injection issue. (#14846). # 11.9.0 - [fixed] Migrate FCM codebase to new NSKeyedUnarchiver APIs. (#14424).