Skip to content

Commit e53c707

Browse files
authored
feat(fdc): Included platform detection changes (#17308)
1 parent af7710a commit e53c707

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

packages/firebase_data_connect/firebase_data_connect/lib/src/common/common_library.dart

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ import 'dart:convert';
1616

1717
import 'package:firebase_app_check/firebase_app_check.dart';
1818

19+
import 'dart:io' show Platform;
20+
21+
import 'package:flutter/foundation.dart';
22+
1923
part 'dataconnect_error.dart';
2024
part 'dataconnect_options.dart';
2125

@@ -26,7 +30,7 @@ String getGoogApiVal(CallerSDKType sdkType, String packageVersion) {
2630
if (sdkType == CallerSDKType.generated) {
2731
apiClientValue += ' dart/gen';
2832
}
29-
return apiClientValue;
33+
return '$apiClientValue gl-${kIsWeb ? 'web' : Platform.operatingSystem}';
3034
}
3135

3236
String getFirebaseClientVal(String packageVersion) {

packages/firebase_data_connect/firebase_data_connect/test/src/common/common_library_test.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import 'package:firebase_data_connect/firebase_data_connect.dart';
1717
import 'package:firebase_data_connect/src/common/common_library.dart';
1818
import 'package:flutter_test/flutter_test.dart';
1919
import 'package:mockito/mockito.dart';
20+
import 'dart:io' show Platform;
2021

2122
// Mock classes for Firebase dependencies
2223

@@ -28,14 +29,14 @@ void main() {
2829
const packageVersion = '1.0.0';
2930
expect(
3031
getGoogApiVal(CallerSDKType.core, packageVersion),
31-
'gl-dart/$packageVersion fire/$packageVersion',
32+
'gl-dart/$packageVersion fire/$packageVersion gl-${Platform.operatingSystem}',
3233
);
3334
});
3435
test('should return codegen suffix if using gen sdk', () {
3536
const packageVersion = '1.0.0';
3637
expect(
3738
getGoogApiVal(CallerSDKType.generated, packageVersion),
38-
'gl-dart/$packageVersion fire/$packageVersion dart/gen',
39+
'gl-dart/$packageVersion fire/$packageVersion dart/gen gl-${Platform.operatingSystem}',
3940
);
4041
});
4142
});

0 commit comments

Comments
 (0)