flashbots: fix bug in double counting gas for profit switcher

jparyani · jparyani · commit 0bf77003840c · 2021-10-04T09:29:44.000-07:00
Only add in the eth sent to coinbase, since the gas fees are counted
already in commitTransaction
diff --git a/miner/worker.go b/miner/worker.go
@@ -1197,7 +1197,7 @@ func (w *worker) commitNewWork(interrupt *int32, noempty bool, timestamp int64)
 		if w.commitBundle(bundleTxs, w.coinbase, interrupt) {
 			return
 		}
-		w.current.profit.Add(w.current.profit, bundle.totalEth)
+		w.current.profit.Add(w.current.profit, bundle.ethSentToCoinbase)
 	}
 	if w.flashbots.isMegabundleWorker {
 		megabundle, err := w.eth.TxPool().GetMegabundle(w.flashbots.relayAddr, header.Number, header.Time)

Original file line number	Diff line number	Diff line change
`@@ -1197,7 +1197,7 @@ func (w worker) commitNewWork(interrupt int32, noempty bool, timestamp int64)`
`1197`	`1197`	`if w.commitBundle(bundleTxs, w.coinbase, interrupt) {`
`1198`	`1198`	`return`
`1199`	`1199`	`}`
`1200`		`- w.current.profit.Add(w.current.profit, bundle.totalEth)`
	`1200`	`+ w.current.profit.Add(w.current.profit, bundle.ethSentToCoinbase)`
`1201`	`1201`	`}`
`1202`	`1202`	`if w.flashbots.isMegabundleWorker {`
`1203`	`1203`	`megabundle, err := w.eth.TxPool().GetMegabundle(w.flashbots.relayAddr, header.Number, header.Time)`