in_splunk: return correct error response for http/1 handler.

Signed-off-by: Phillip Whelan <[email protected]>

Author: pwhelan

plugins/in_splunk/splunk_prot.c

@@ -887,10 +887,12 @@ int splunk_prot_handle(struct flb_splunk *ctx, struct splunk_conn *conn,
                 return -1;
             }
 
-            if (!ret) {
+            if (ret < 0) {
                 send_json_message_response(conn, 400, "{\"text\":\"Invalid data format\",\"code\":6}");
             }
-            send_json_message_response(conn, 200, "{\"text\":\"Success\",\"code\":0}");
+            else {
+                send_json_message_response(conn, 200, "{\"text\":\"Success\",\"code\":0}");
+            }
         }
         else if (strcasecmp(uri, "/services/collector/event/1.0") == 0 ||
                  strcasecmp(uri, "/services/collector/event") == 0 ||
@@ -910,10 +912,12 @@ int splunk_prot_handle(struct flb_splunk *ctx, struct splunk_conn *conn,
                 return -1;
             }
 
-            if (!ret) {
+            if (ret < 0) {
                 send_json_message_response(conn, 400, "{\"text\":\"Invalid data format\",\"code\":6}");
             }
-            send_json_message_response(conn, 200, "{\"text\":\"Success\",\"code\":0}");
+            else {
+                send_json_message_response(conn, 200, "{\"text\":\"Success\",\"code\":0}");
+            }
         }
         else {
             send_response(conn, 400, "error: invalid HTTP endpoint\n");
@@ -1268,4 +1272,4 @@ int splunk_prot_handle_ng(struct flb_http_request *request,
 
     flb_sds_destroy(tag);
     return ret;
-}
+}