Skip to content

Commit 08614a7

Browse files
[many] Update example android apps to target SDK level 34. (#7587)
Bump up target SDK for each Android example app, bump version and changelog, and as necessary export activities and update permissions. For each package, I ensured the example app ran on an emulator before and after the upgrade and compared its behavior, as well as running the integration tests to confirm they pass. flutter/flutter#152929 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [ ] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes]. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version [following repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
1 parent 218fd4a commit 08614a7

File tree

22 files changed

+35
-20
lines changed

22 files changed

+35
-20
lines changed

packages/file_selector/file_selector_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ android {
4141
// You can update the following values to match your application needs.
4242
// For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-gradle-build-configuration.
4343
minSdkVersion 21
44-
targetSdkVersion 33
44+
targetSdkVersion 34
4545
versionCode flutterVersionCode.toInteger()
4646
versionName flutterVersionName
4747
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"

packages/flutter_plugin_android_lifecycle/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ android {
3232
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
3333
applicationId "io.flutter.plugins.flutter_plugin_android_lifecycle_example"
3434
minSdkVersion flutter.minSdkVersion
35-
targetSdkVersion 28
35+
targetSdkVersion 34
3636
versionCode flutterVersionCode.toInteger()
3737
versionName flutterVersionName
3838
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"

packages/flutter_plugin_android_lifecycle/example/android/app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
android:icon="@mipmap/ic_launcher">
55
<activity
66
android:name=".MainActivity"
7+
android:exported="true"
78
android:launchMode="singleTop"
89
android:theme="@style/LaunchTheme"
910
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale|layoutDirection|fontScale|screenLayout|density|uiMode"

packages/google_maps_flutter/google_maps_flutter_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ android {
3232
defaultConfig {
3333
applicationId "io.flutter.plugins.googlemapsexample"
3434
minSdkVersion flutter.minSdkVersion
35-
targetSdkVersion 28
35+
targetSdkVersion 34
3636
multiDexEnabled true
3737
versionCode flutterVersionCode.toInteger()
3838
versionName flutterVersionName

packages/google_maps_flutter/google_maps_flutter_android/example/android/app/src/main/AndroidManifest.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
2+
xmlns:tools="http://schemas.android.com/tools"
23
package="io.flutter.plugins.googlemapsexample">
34

45
<uses-permission android:name="android.permission.INTERNET"/>
5-
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>
6+
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"
7+
tools:ignore="CoarseFineLocation" />
68

79
<application android:label="google_maps_flutter_example" android:icon="@mipmap/ic_launcher">
810
<meta-data
@@ -13,6 +15,7 @@
1315
android:name="com.google.android.geo.API_KEY"
1416
android:value="${mapsApiKey}" />
1517
<activity android:name="io.flutter.embedding.android.FlutterActivity"
18+
android:exported="true"
1619
android:theme="@style/LaunchTheme"
1720
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale|layoutDirection|fontScale"
1821
android:hardwareAccelerated="true"

packages/google_sign_in/google_sign_in_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ android {
3232
defaultConfig {
3333
applicationId "io.flutter.plugins.googlesigninexample"
3434
minSdkVersion flutter.minSdkVersion
35-
targetSdkVersion 28
35+
targetSdkVersion 34
3636
multiDexEnabled true
3737
versionCode flutterVersionCode.toInteger()
3838
versionName flutterVersionName

packages/google_sign_in/google_sign_in_android/example/android/app/src/main/AndroidManifest.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55

66
<application>
77
<activity android:name="io.flutter.embedding.android.FlutterActivity"
8-
android:theme="@android:style/Theme.Black.NoTitleBar"
8+
android:exported="true"
9+
android:theme="@android:style/Theme.Black.NoTitleBar"
910
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale|layoutDirection"
1011
android:hardwareAccelerated="true"
1112
android:windowSoftInputMode="adjustResize">

packages/image_picker/image_picker_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ android {
3333
defaultConfig {
3434
applicationId "io.flutter.plugins.imagepicker.example"
3535
minSdkVersion flutter.minSdkVersion
36-
targetSdkVersion 33
36+
targetSdkVersion 34
3737
multiDexEnabled true
3838
versionCode flutterVersionCode.toInteger()
3939
versionName flutterVersionName

packages/local_auth/local_auth_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ android {
3232
defaultConfig {
3333
applicationId "io.flutter.plugins.localauthexample"
3434
minSdkVersion flutter.minSdkVersion
35-
targetSdkVersion 28
35+
targetSdkVersion 34
3636
versionCode flutterVersionCode.toInteger()
3737
versionName flutterVersionName
3838
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"

packages/local_auth/local_auth_android/example/android/app/src/main/AndroidManifest.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66

77
<application android:label="local_auth_example" android:icon="@mipmap/ic_launcher">
88
<activity android:name="io.flutter.embedding.android.FlutterFragmentActivity"
9-
android:launchMode="singleTop"
9+
android:exported="true"
10+
android:launchMode="singleTop"
1011
android:theme="@style/Theme.AppCompat.Light"
1112
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale|layoutDirection"
1213
android:hardwareAccelerated="true"

0 commit comments

Comments
 (0)