Skip to content

Conversation

@joedborg
Copy link

An attempt at fixing #1671. I'm not much of a Go wizard, so it probably requires some cleanup.

This adds the ability to add --metrics-server-secret-ref to give the ability to auth against external Prometheus endpoints.

@joedborg joedborg requested a review from stefanprodan as a code owner June 28, 2024 16:25
Signed-off-by: Joe Borg <[email protected]>
@joedborg
Copy link
Author

@stefanprodan and chance I can get a review on this please?

@aryan9600
Copy link
Member

is it not possible to define custom MetricTemplate objects pointing to the prom server with the appropriate credentials? the query can be copy pasted from flagger's codebase. that's hardcoded anyway: https://github.com/fluxcd/flagger/blob/main/pkg/metrics/observers/istio.go#L27

@joedborg
Copy link
Author

@aryan9600 that's what I'm doing as a work around but I'd like the built ins to work as described without having to duplicate code from the repo to get it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants