Only read global settings once

Author: minhqdao

src/fpm/dependency.f90

@@ -524,10 +524,14 @@ subroutine resolve_dependencies(self, root, error)
     !> Error handling
     type(error_t), allocatable, intent(out) :: error
 
+    type(fpm_global_settings) :: global_settings
     integer :: ii
 
+    call get_global_settings(global_settings, error)
+    if (allocated(error)) return
+
     do ii = 1, self%ndep
-      call self%resolve(self%dep(ii), root, error)
+      call self%resolve(self%dep(ii), global_settings, root, error)
       if (allocated(error)) exit
     end do
 
@@ -536,19 +540,20 @@ subroutine resolve_dependencies(self, root, error)
   end subroutine resolve_dependencies
 
   !> Resolve a single dependency node
-  subroutine resolve_dependency(self, dependency, root, error)
+  subroutine resolve_dependency(self, dependency, global_settings, root, error)
     !> Instance of the dependency tree
     class(dependency_tree_t), intent(inout) :: self
     !> Dependency configuration to add
     type(dependency_node_t), intent(inout) :: dependency
+    !> Global configuration settings.
+    type(fpm_global_settings), intent(in) :: global_settings
     !> Current installation prefix
     character(len=*), intent(in) :: root
     !> Error handling
     type(error_t), allocatable, intent(out) :: error
 
     type(package_config_t) :: package
     character(len=:), allocatable :: manifest, proj_dir, revision
-    type(fpm_global_settings) :: global_settings
     logical :: fetch
 
     if (dependency%done) return
@@ -565,8 +570,6 @@ subroutine resolve_dependency(self, dependency, root, error)
         if (allocated(error)) return
       end if
     else
-      call get_global_settings(global_settings, error)
-      if (allocated(error)) return
       call dependency%get_from_registry(proj_dir, global_settings, error)
       if (allocated(error)) return
     end if

test/fpm_test/test_package_dependencies.f90

@@ -1314,11 +1314,13 @@ subroutine pkg_data_invalid_version(error)
   end subroutine pkg_data_invalid_version
 
   !> Resolve a single dependency node
-  subroutine resolve_dependency_once(self, dependency, root, error)
+  subroutine resolve_dependency_once(self, dependency, global_settings, root, error)
     !> Mock instance of the dependency tree
     class(mock_dependency_tree_t), intent(inout) :: self
     !> Dependency configuration to add
     type(dependency_node_t), intent(inout) :: dependency
+    !> Global configuration settings.
+    type(fpm_global_settings), intent(in) :: global_settings
     !> Current installation prefix
     character(len=*), intent(in) :: root
     !> Error handling