fix(php72): fix builds on php<=7.2 for darwin

Author: HelloWorld017

pkgs/php/7.3.nix

@@ -13,15 +13,6 @@ let
           url = "https://github.com/NixOS/nixpkgs/raw/42e9a2ccfab2a96d28c3c164a6cf41fb6f769de5/pkgs/development/interpreters/php/php73-darwin-isfinite.patch";
           sha256 = "V0mLLmXa2qJyxIVW/7nEml6cXZTBbr42kkJiij9KPyk=";
         })
-        # Handle macos versions that don't start with 10.* in libtool.
-        # https://github.com/php/php-src/commit/d016434ad33284dfaceb8d233351d34356566d7d
-        (prev.pkgs.fetchpatch2 {
-          url = "https://github.com/php/php-src/commit/d016434ad33284dfaceb8d233351d34356566d7d.patch";
-          sha256 = "sha256-x0vEcoXNFeQi3re1TrK/Np9AH5dy3wf95xM08xCyGE0=";
-          includes = [
-            "build/libtool.m4"
-          ];
-        })
     ];
   };
 in

pkgs/phps.nix

@@ -33,6 +33,17 @@ let
                 url = "https://bugs.php.net/patch-display.php?bug_id=76826&patch=bug76826.poc.0.patch&revision=1538723399&download=1";
                 sha256 = "aW+MW9Kb8N/yBO7MdqZMZzgMSF7b+IMLulJKgKPWrUA=";
               })
+            ]
+            ++ prev.lib.optionals (prev.lib.versionOlder args.version "7.4" && prev.stdenv.isDarwin) [
+              # Handle macos versions that don't start with 10.* in libtool.
+              # https://github.com/php/php-src/commit/d016434ad33284dfaceb8d233351d34356566d7d
+              (prev.pkgs.fetchpatch2 {
+                url = "https://github.com/php/php-src/commit/d016434ad33284dfaceb8d233351d34356566d7d.patch";
+                sha256 = "sha256-x0vEcoXNFeQi3re1TrK/Np9AH5dy3wf95xM08xCyGE0=";
+                includes = [
+                  "build/libtool.m4"
+                ];
+              })
             ];
 
           configureFlags =
@@ -43,9 +54,14 @@ let
 
               "--enable-libxml"
               "--with-libxml-dir=${prev.libxml2.dev}"
+              (
+                if prev.lib.versionAtLeast args.version "7.3"
+                then "--with-pcre-regex=${prev.pcre2.dev}"
+                else "--with-pcre-regex=${prev.pcre.dev}"
+              )
             ]
-            ++ prev.lib.optionals (prev.lib.versionAtLeast args.version "7.3") [
-              "--with-pcre-regex=${prev.pcre2.dev}"
+            ++ prev.lib.optionals (prev.lib.versionOlder args.version "7.3") [
+              "PCRE_LIBDIR=${prev.pcre}"
             ];
 
           buildInputs =