php73: fix builds on darwin architecture

Author: drupol

pkgs/patches/php73-libtool.patch

@@ -0,0 +1,20 @@
+diff -ru a/build/libtool.m4 b/build/libtool.m4
+--- a/build/libtool.m4
++++ b/build/libtool.m4
+@@ -340,7 +340,7 @@ AC_DEFUN([_LT_REQUIRED_DARWIN_CHECKS],[
+      _lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
+    10.[[012]]*)
+      _lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
+-   10.*)
++   *)
+      _lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
+       esac
+     ;;
+@@ -5799,7 +5799,7 @@ _LT_EOF
+              10.[[012]])
+                _LT_AC_TAGVAR(allow_undefined_flag, $1)='${wl}-flat_namespace ${wl}-undefined ${wl}suppress'
+                ;;
+-             10.*)
++             *)
+                _LT_AC_TAGVAR(allow_undefined_flag, $1)='${wl}-undefined ${wl}dynamic_lookup'
+                ;;

pkgs/php/7.3.nix

@@ -13,7 +13,16 @@ let
           url = "https://github.com/NixOS/nixpkgs/raw/42e9a2ccfab2a96d28c3c164a6cf41fb6f769de5/pkgs/development/interpreters/php/php73-darwin-isfinite.patch";
           sha256 = "V0mLLmXa2qJyxIVW/7nEml6cXZTBbr42kkJiij9KPyk=";
         })
-      ];
+        # Handle macos versions that don't start with 10.* in libtool.
+        # https://github.com/php/php-src/commit/d016434ad33284dfaceb8d233351d34356566d7d
+        (prev.pkgs.fetchpatch2 {
+          url = "https://github.com/php/php-src/commit/d016434ad33284dfaceb8d233351d34356566d7d.patch";
+          sha256 = "";
+          includes = [
+            "build/libtool.m4"
+          ];
+        })
+    ];
   };
 in
 base.withExtensions (

pkgs/phps.nix

@@ -43,6 +43,9 @@ let
 
               "--enable-libxml"
               "--with-libxml-dir=${prev.libxml2.dev}"
+            ]
+            ++ prev.lib.optionals (prev.lib.versionAtLeast args.version "7.3") [
+              "--with-pcre-regex=${prev.pcre2.dev}"
             ];
 
           buildInputs =