Add no content warnings and only call text_contents detectors when there is content text, add Message::has_content

Signed-off-by: declark1 <[email protected]>

Author: declark1

src/clients/openai.rs

@@ -597,10 +597,17 @@ impl Message {
     /// Returns message text content.
     pub fn text(&self) -> Option<&String> {
         match &self.content {
-            Some(Content::Text(text)) => Some(text),
+            Some(Content::Text(text)) if !text.is_empty() => Some(text),
             _ => None,
         }
     }
+
+    /// Returns `true` if message contains non-empty content.
+    pub fn has_content(&self) -> bool {
+        self.content
+            .as_ref()
+            .is_some_and(|content| !content.is_empty())
+    }
 }
 
 /// Content.

src/orchestrator/handlers/chat_completions_detection/streaming.rs

@@ -486,17 +486,27 @@ async fn handle_whole_doc_detection(
     // Spawn detection tasks
     let mut tasks = Vec::with_capacity(choices.len() * detector_groups.len());
     for (choice_index, message) in &choices {
+        if !message.has_content() {
+            // Add no content warning
+            warnings.push(CompletionDetectionWarning::new(
+                DetectionWarningReason::EmptyOutput,
+                &format!("Choice of index {} has no content", choice_index),
+            ));
+        }
         for (detector_type, detectors) in &detector_groups {
             let detection_task = match detector_type {
-                TextContents => tokio::spawn(
-                    common::text_contents_detections(
-                        ctx.clone(),
-                        headers.clone(),
-                        detectors.clone(),
-                        vec![(0, message.text().cloned().unwrap_or_default())],
-                    )
-                    .in_current_span(),
-                ),
+                TextContents => match message.text() {
+                    Some(content_text) => tokio::spawn(
+                        common::text_contents_detections(
+                            ctx.clone(),
+                            headers.clone(),
+                            detectors.clone(),
+                            vec![(0, content_text.clone())],
+                        )
+                        .in_current_span(),
+                    ),
+                    _ => continue, // no content, skip
+                },
                 TextChat => tokio::spawn(
                     common::text_chat_detections(
                         ctx.clone(),

src/orchestrator/handlers/chat_completions_detection/unary.rs

@@ -194,17 +194,29 @@ async fn handle_output_detection(
     // Spawn detection tasks
     let mut tasks = Vec::with_capacity(chat_completion.choices.len() * detector_groups.len());
     for choice in &chat_completion.choices {
+        if !choice.message.has_content() {
+            // Add no content warning
+            chat_completion
+                .warnings
+                .push(CompletionDetectionWarning::new(
+                    DetectionWarningReason::EmptyOutput,
+                    &format!("Choice of index {} has no content", choice.index),
+                ));
+        }
         for (detector_type, detectors) in &detector_groups {
             let detection_task = match detector_type {
-                TextContents => tokio::spawn(
-                    common::text_contents_detections(
-                        ctx.clone(),
-                        headers.clone(),
-                        detectors.clone(),
-                        vec![(0, choice.message.text().cloned().unwrap_or_default())],
-                    )
-                    .in_current_span(),
-                ),
+                TextContents => match choice.message.text() {
+                    Some(content_text) => tokio::spawn(
+                        common::text_contents_detections(
+                            ctx.clone(),
+                            headers.clone(),
+                            detectors.clone(),
+                            vec![(0, content_text.clone())],
+                        )
+                        .in_current_span(),
+                    ),
+                    _ => continue, // no content, skip
+                },
                 TextChat => tokio::spawn(
                     common::text_chat_detections(
                         ctx.clone(),