chore(script): avoid cloning script sequences when writing sensitive output (#12085)

* chore(script): avoid cloning script sequences when writing sensitive output

* Update sequence.rs

* Update multi_sequence.rs

* Update sequence.rs

* Update multi_sequence.rs

Author: Bilogweb3

crates/script-sequence/src/sequence.rs

@@ -51,8 +51,8 @@ pub struct SensitiveScriptSequence {
     pub transactions: VecDeque<SensitiveTransactionMetadata>,
 }
 
-impl From<ScriptSequence> for SensitiveScriptSequence {
-    fn from(sequence: ScriptSequence) -> Self {
+impl From<&ScriptSequence> for SensitiveScriptSequence {
+    fn from(sequence: &ScriptSequence) -> Self {
         Self {
             transactions: sequence
                 .transactions
@@ -99,31 +99,31 @@ impl ScriptSequence {
             return Ok(());
         }
 
-        let Some((path, sensitive_path)) = self.paths.clone() else { return Ok(()) };
-
         self.timestamp = now().as_millis();
         let ts_name = format!("run-{}.json", self.timestamp);
 
-        let sensitive_script_sequence: SensitiveScriptSequence = self.clone().into();
+        let sensitive_script_sequence = SensitiveScriptSequence::from(&*self);
+
+        let Some((path, sensitive_path)) = self.paths.as_ref() else { return Ok(()) };
 
         // broadcast folder writes
         //../run-latest.json
-        let mut writer = BufWriter::new(fs::create_file(&path)?);
+        let mut writer = BufWriter::new(fs::create_file(path)?);
         serde_json::to_writer_pretty(&mut writer, &self)?;
         writer.flush()?;
         if save_ts {
             //../run-[timestamp].json
-            fs::copy(&path, path.with_file_name(&ts_name))?;
+            fs::copy(path, path.with_file_name(&ts_name))?;
         }
 
         // cache folder writes
         //../run-latest.json
-        let mut writer = BufWriter::new(fs::create_file(&sensitive_path)?);
+        let mut writer = BufWriter::new(fs::create_file(sensitive_path)?);
         serde_json::to_writer_pretty(&mut writer, &sensitive_script_sequence)?;
         writer.flush()?;
         if save_ts {
             //../run-[timestamp].json
-            fs::copy(&sensitive_path, sensitive_path.with_file_name(&ts_name))?;
+            fs::copy(sensitive_path, sensitive_path.with_file_name(&ts_name))?;
         }
 
         if !silent {

crates/script/src/multi_sequence.rs

@@ -29,9 +29,9 @@ pub struct SensitiveMultiChainSequence {
 }
 
 impl SensitiveMultiChainSequence {
-    fn from_multi_sequence(sequence: MultiChainSequence) -> Self {
+    fn from_multi_sequence(sequence: &MultiChainSequence) -> Self {
         Self {
-            deployments: sequence.deployments.into_iter().map(|sequence| sequence.into()).collect(),
+            deployments: sequence.deployments.iter().map(SensitiveScriptSequence::from).collect(),
         }
     }
 }
@@ -115,7 +115,7 @@ impl MultiChainSequence {
 
         self.timestamp = now().as_millis();
 
-        let sensitive_sequence = SensitiveMultiChainSequence::from_multi_sequence(self.clone());
+        let sensitive_sequence = SensitiveMultiChainSequence::from_multi_sequence(&*self);
 
         // broadcast writes
         //../Contract-latest/run.json