-
Notifications
You must be signed in to change notification settings - Fork 240
Refactor configuration package
#3844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| use crate::Config; | ||
| use anyhow::anyhow; | ||
| use serde_json::Number; | ||
| use std::env; | ||
|
|
||
| fn resolve_env_variables(config: serde_json::Value) -> anyhow::Result<serde_json::Value> { | ||
| match config { | ||
| serde_json::Value::Object(map) => { | ||
| let val = map | ||
| .into_iter() | ||
| .map(|(k, v)| -> anyhow::Result<(String, serde_json::Value)> { | ||
| Ok((k, resolve_env_variables(v)?)) | ||
| }) | ||
| .collect::<anyhow::Result<serde_json::Map<String, serde_json::Value>>>()?; | ||
| Ok(serde_json::Value::Object(val)) | ||
| } | ||
| serde_json::Value::Array(val) => { | ||
| let val = val | ||
| .into_iter() | ||
| .map(resolve_env_variables) | ||
| .collect::<anyhow::Result<Vec<serde_json::Value>>>()?; | ||
| Ok(serde_json::Value::Array(val)) | ||
| } | ||
| serde_json::Value::String(val) if val.starts_with('$') => resolve_env_variable(&val), | ||
| val => Ok(val), | ||
| } | ||
| } | ||
|
|
||
| fn resolve_env_variable(var: &str) -> anyhow::Result<serde_json::Value> { | ||
| assert!(var.starts_with('$')); | ||
| let mut initial_value = &var[1..]; | ||
| if initial_value.starts_with('{') && initial_value.ends_with('}') { | ||
| initial_value = &initial_value[1..initial_value.len() - 1]; | ||
| } | ||
| let value = env::var(initial_value)?; | ||
|
|
||
| if let Ok(value) = value.parse::<Number>() { | ||
| return Ok(serde_json::Value::Number(value)); | ||
| } | ||
| if let Ok(value) = value.parse::<bool>() { | ||
| return Ok(serde_json::Value::Bool(value)); | ||
| } | ||
| Ok(serde_json::Value::String(value)) | ||
| } | ||
|
|
||
| fn get_with_ownership(config: serde_json::Value, key: &str) -> Option<serde_json::Value> { | ||
| match config { | ||
| serde_json::Value::Object(mut map) => map.remove(key), | ||
| _ => None, | ||
| } | ||
| } | ||
|
|
||
| fn get_profile( | ||
| raw_config: serde_json::Value, | ||
| tool: &str, | ||
| profile: &str, | ||
| ) -> Option<serde_json::Value> { | ||
| let profile_name = profile; | ||
| let tool_config = get_with_ownership(raw_config, tool) | ||
| .unwrap_or(serde_json::Value::Object(serde_json::Map::new())); | ||
|
|
||
| get_with_ownership(tool_config, profile_name) | ||
| } | ||
|
|
||
| pub enum Profile { | ||
| None, | ||
| Default, | ||
| Some(String), | ||
| } | ||
|
|
||
| pub fn load_config<T: Config + Default>( | ||
| raw_config: serde_json::Value, | ||
| profile: Profile, | ||
| ) -> anyhow::Result<T> { | ||
| let raw_config_json = match profile { | ||
| Profile::None => raw_config, | ||
| Profile::Default => get_profile(raw_config, T::tool_name(), "default") | ||
| .unwrap_or_else(|| serde_json::Value::Object(serde_json::Map::new())), | ||
| Profile::Some(profile) => get_profile(raw_config, T::tool_name(), &profile) | ||
| .ok_or_else(|| anyhow!("Profile [{profile}] not found in config"))?, | ||
| }; | ||
| T::from_raw(resolve_env_variables(raw_config_json)?) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| use crate::CONFIG_FILENAME; | ||
| use std::fs; | ||
| use tempfile::{TempDir, tempdir}; | ||
|
|
||
| #[must_use] | ||
| pub fn copy_config_to_tempdir(src_path: &str, additional_path: Option<&str>) -> TempDir { | ||
| let temp_dir = tempdir().expect("Failed to create a temporary directory"); | ||
| if let Some(dir) = additional_path { | ||
| let path = temp_dir.path().join(dir); | ||
| fs::create_dir_all(path).expect("Failed to create directories in temp dir"); | ||
| } | ||
| let temp_dir_file_path = temp_dir.path().join(CONFIG_FILENAME); | ||
| fs::copy(src_path, temp_dir_file_path).expect("Failed to copy config file to temp dir"); | ||
|
|
||
| temp_dir | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.