add a package.xml #142
Closed
add a package.xml #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-rauch
force-pushed
the
package-xml
branch
from
7c09f8c to
ae0575a
Compare
Author
|
@falfab @BarisYazici Can you have a look at this? |
christian-rauch
force-pushed
the
package-xml
branch
from
ae0575a to
f5dbbec
Compare
|
Hi Christian, Those changes are introduced to libfranka from 0.13.3 version. Thanks for contributing! |
Author
|
See #162 for a backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
package.xmlfile and disables tests by default for a better "build from source" experience.The
package.xmlhas been adapted from https://github.com/frankaemika/libfranka-release/blob/master/foxy/package.xml. I changed<build_type>ament_cmake</build_type>from the original file to<build_type>cmake</build_type>as theCMakeLists.txtis a "pure" CMake project without any ROS 2 (or ament) dependencies.