Skip to content

- First version of asigra hotfix / update script #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

- First version of asigra hotfix / update script #8

wants to merge 1 commit into from

Conversation

@miwi-fbsd
Copy link

@miwi-fbsd miwi-fbsd commented Jun 13, 2019

  • Script check the index file for new updates
  • If update available download and auto install
  • Cron is not enabled yet till we have test feedback

william-gr
william-gr requested changes Jun 13, 2019
View reviewed changes
Copy link
Member

@william-gr william-gr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we are tackling this the wrong way.

Updating packages behind the users back is confusing to say the least.

We should be adding these as ports in iocage ports repo and make the plugin version come from one of these ports/packages.

skarekrow
skarekrow suggested changes Jun 13, 2019
View reviewed changes
Copy link

@skarekrow skarekrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this is what postupgrade.sh is for. Let's use the correct mechanisms.

@kmoore134
Copy link
Contributor

kmoore134 commented Jun 13, 2019

@william-gr Agree that probably ports for the ds-system / ds-operator files makes sense. However what about DS-Client? Those are 3.6GB! in size and not sure we want to require that to be installed at plugin install time?

@william-gr
Copy link
Member

william-gr commented Jun 13, 2019 •
edited
Loading

@kmoore134 yes, I meant it only for those. The DS-Client can/should be done in background

william-gr
william-gr reviewed Jun 13, 2019
View reviewed changes
overlay/etc/cron.d/asigra-update.sh
-O $UPDATE/$i \
--fail-early \
--connect-timeout 5 \
--max-time 300 \
Copy link
Member

@william-gr william-gr Jun 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

300 seconds is enough to download 3.6GiB?

Copy link
Author

@miwi-fbsd miwi-fbsd Jun 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, thats always dependents on network and location (home or dc), do you think 1200 sec (20 min) would be a good time ?

Copy link
Member

@william-gr william-gr Jun 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try 2 hours. 10mbit/s connections are still popular around the world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@william-gr william-gr william-gr requested changes

@kmoore134 kmoore134 Awaiting requested review from kmoore134

+1 more reviewer

@skarekrow skarekrow skarekrow requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miwi-fbsd @kmoore134 @william-gr @skarekrow