Skip to content

Avoid zombie processes, There is no wait subprocess state, which may lead to zombie process in subprocesses. #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid zombie processes, There is no wait subprocess state, which may lead to zombie process in subprocesses. #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f836c50
Avoid zombie processes
thinkeridea Jan 18, 2020
b3efcfb
Active termination to eliminate http.Serve error messages
thinkeridea Jan 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions endless.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,10 @@ func (srv *endlessServer) Serve() (err error) {
defer log.Println(syscall.Getpid(), "Serve() returning...")
srv.setState(STATE_RUNNING)
err = srv.Server.Serve(srv.EndlessListener)
// Active termination to eliminate error messages
if srv.getState() != STATE_RUNNING{
err = nil
}
log.Println(syscall.Getpid(), "Waiting for connections to finish...")
srv.wg.Wait()
srv.setState(STATE_TERMINATE)
Expand Down Expand Up @@ -477,6 +481,10 @@ func (srv *endlessServer) fork() (err error) {
log.Fatalf("Restart: Failed to launch, error: %v", err)
}

go func() {
// Avoid zombie processes, There is no wait subprocess state, which may lead to zombie process in subprocesses.
cmd.Wait()
}()
return
}

Expand Down