Swap to lucide-vue-next, drop warning suppression

Author: dannon

client/package.json

@@ -86,7 +86,8 @@
     "linkify-html": "^4.1.1",
     "linkifyjs": "^4.1.1",
     "lodash.isequal": "^4.5.0",
-    "lucide-vue": "^0.344.0",
+    "lucide-vue": "^0.517.0",
+    "lucide-vue-next": "^0.540.0",
     "markdown-it": "^13.0.2",
     "markdown-it-regexp": "^0.4.0",
     "mitt": "^3.0.1",

client/src/components/History/Content/ContentItem.test.js

@@ -1,6 +1,6 @@
 import { createTestingPinia } from "@pinia/testing";
 import { mount } from "@vue/test-utils";
-import { getLocalVue, suppressLucideVue2Deprecation } from "tests/jest/helpers";
+import { getLocalVue } from "tests/jest/helpers";
 
 import { HttpResponse, useServerMock } from "@/api/client/__mocks__";
 import { updateContentFields } from "@/components/History/model/queries";
@@ -33,8 +33,6 @@ describe("ContentItem", () => {
     let wrapper;
 
     beforeEach(() => {
-        suppressLucideVue2Deprecation();
-
         server.use(
             http.get("/api/datasets/{dataset_id}", ({ response }) => {
                 // We need to use untyped here because this endpoint is not

client/src/components/History/Content/ContentOptions.vue

@@ -3,8 +3,7 @@ import { faStop } from "@fortawesome/free-solid-svg-icons";
 import { FontAwesomeIcon } from "@fortawesome/vue-fontawesome";
 import axios from "axios";
 import { BButton, BDropdown } from "bootstrap-vue";
-//@ts-ignore deprecated package without types (vue 2, remove this comment on vue 3 migration)
-import { ScanEye } from "lucide-vue";
+import { ScanEye } from "lucide-vue-next";
 import { computed, type Ref, ref } from "vue";
 
 import { getAppRoot } from "@/onload/loadConfig";

client/src/components/History/Content/GenericElement.test.js

@@ -1,6 +1,6 @@
 import { createTestingPinia } from "@pinia/testing";
 import { mount } from "@vue/test-utils";
-import { getLocalVue, suppressLucideVue2Deprecation } from "tests/jest/helpers";
+import { getLocalVue } from "tests/jest/helpers";
 
 import GenericElement from "./GenericElement";
 
@@ -12,7 +12,6 @@ describe("GenericElement", () => {
     let wrapper;
 
     beforeEach(() => {
-        suppressLucideVue2Deprecation();
 
         wrapper = mount(GenericElement, {
             props: {

client/src/components/History/HistoryView.test.js

@@ -2,7 +2,7 @@ import { getFakeRegisteredUser } from "@tests/test-data";
 import { mount } from "@vue/test-utils";
 import flushPromises from "flush-promises";
 import { createPinia } from "pinia";
-import { getLocalVue, suppressLucideVue2Deprecation } from "tests/jest/helpers";
+import { getLocalVue } from "tests/jest/helpers";
 import { setupMockConfig } from "tests/jest/mockConfig";
 import VueRouter from "vue-router";
 
@@ -117,10 +117,6 @@ async function createWrapper(globalConfig, currentUserId, history) {
 }
 
 describe("History center panel View", () => {
-    beforeEach(() => {
-        suppressLucideVue2Deprecation();
-    });
-
     function expectCorrectLayout(wrapper) {
         // HistoryFilters should exist in HistoryView
         expect(wrapper.find("[data-description='filter text input']").exists()).toBe(true);

client/src/components/Workflow/Editor/NodeInspector.vue

@@ -2,8 +2,7 @@
 import { faCog, faTimes } from "@fortawesome/free-solid-svg-icons";
 import { FontAwesomeIcon } from "@fortawesome/vue-fontawesome";
 import { BButton, BButtonGroup, BDropdown, BDropdownForm, BDropdownItemButton, BFormCheckbox } from "bootstrap-vue";
-//@ts-ignore deprecated package without types (vue 2, remove this comment on vue 3 migration)
-import { ArrowLeftFromLine, ArrowRightToLine } from "lucide-vue";
+import { ArrowLeftFromLine, ArrowRightToLine } from "lucide-vue-next";
 import { computed } from "vue";
 
 import { useWorkflowNodeInspectorStore } from "@/stores/workflowNodeInspectorStore";

client/src/components/Workflow/Editor/Tools/ToolBar.vue

@@ -16,8 +16,7 @@ import {
 import { FontAwesomeIcon } from "@fortawesome/vue-fontawesome";
 import { useMagicKeys, whenever } from "@vueuse/core";
 import { BFormInput } from "bootstrap-vue";
-//@ts-ignore deprecated package without types (vue 2, remove this comment on vue 3 migration)
-import { BoxSelect, Workflow } from "lucide-vue";
+import { BoxSelect, Workflow } from "lucide-vue-next";
 import { storeToRefs } from "pinia";
 import { computed, toRefs, watch } from "vue";
 

client/tests/jest/helpers.js

@@ -378,15 +378,3 @@ export function suppressErrorForCustomIcons() {
         }
     });
 }
-
-export function suppressLucideVue2Deprecation() {
-    const originalWarn = console.warn;
-    // Only mock if not already mocked to prevent recursion
-    if (!console.warn._isMockFunction) {
-        jest.spyOn(console, "warn").mockImplementation((msg) => {
-            if (!msg || typeof msg !== "string" || msg.indexOf("[Lucide Vue] This package will be deprecated") < 0) {
-                originalWarn.call(console, msg);
-            }
-        });
-    }
-}

client/yarn.lock

@@ -8988,10 +8988,15 @@ lru-cache@^6.0.0:
   resolved "https://registry.yarnpkg.com/lru-cache/-/lru-cache-10.0.1.tgz#0a3be479df549cca0e5d693ac402ff19537a6b7a"
   integrity sha512-IJ4uwUTi2qCccrioU6g9g/5rvvVl13bsdczUUcqbciD9iLr095yj8DQKdObriEvuNSx325N1rV1O0sJFszx75g==
 
-lucide-vue@^0.344.0:
-  version "0.344.0"
-  resolved "https://registry.yarnpkg.com/lucide-vue/-/lucide-vue-0.344.0.tgz#e1c281e352b814aac31db56d0bd99b0205e40e56"
-  integrity sha512-pful6clOPphjOjuVaD/D1Lf7VW8dI58TxKvN+veOQZ2EK3jJr5Jv5a32wG1sDOvW/rw5w+nZ7qha6INvWtZDdQ==
+lucide-vue-next@^0.540.0:
+  version "0.540.0"
+  resolved "https://registry.yarnpkg.com/lucide-vue-next/-/lucide-vue-next-0.540.0.tgz#c432f94651cf724b52ba0dd39d5e7a3891ed93b0"
+  integrity sha512-H7qhKVNKLyoFMo05pWcGSWBiLPiI3zJmWV65SuXWHlrIGIcvDer10xAyWcRJ0KLzIH5k5+yi7AGw/Xi1VF8Pbw==
+
+lucide-vue@^0.517.0:
+  version "0.517.0"
+  resolved "https://registry.yarnpkg.com/lucide-vue/-/lucide-vue-0.517.0.tgz#b8fd325f0f9d6c1d627897be842b4234d25754f0"
+  integrity sha512-ctSLCEslH5DchFq+/jku2cjQoBago2Q8EkK5i32hZaFVPV/6iUe1NjycwmIQLdprvEhnvNQxJbmEHUO5v41myw==
 
 magic-string@^0.30.17:
   version "0.30.17"