ref: Remove v9 checks for debug image provider (#6454)

Author: noahsmartin

Sentry.xcodeproj/project.pbxproj

@@ -29,7 +29,6 @@
 #import "SentryCrashCachedData.h"
 #import "SentryCrashInstallation+Private.h"
 #import "SentryCrashMonitor_MachException.h"
-#import "SentryDebugImageProvider+HybridSDKs.h"
 #import "SentryDefaultThreadInspector.h"
 #import "SentryDependencyContainer.h"
 #import "SentryFileManager+Test.h"

SentryTestUtils/SentryTestUtils-ObjC-BridgingHeader.h

@@ -1,19 +1,9 @@
 import _SentryPrivate
 import Foundation
-@testable import Sentry
+@_spi(Private) @testable import Sentry
 
-public class TestDebugImageProvider: SentryDebugImageProvider {
+@_spi(Private) public class TestDebugImageProvider: SentryDebugImageProvider {
     public var debugImages: [DebugMeta]?
-
-    @available(*, deprecated)
-    public override func getDebugImages() -> [DebugMeta] {
-        getDebugImagesCrashed(true)
-    }
-
-    @available(*, deprecated)
-    public override func getDebugImagesCrashed(_ isCrash: Bool) -> [DebugMeta] {
-        debugImages ?? super.getDebugImagesCrashed(isCrash)
-    }
 
     public var getDebugImagesFromCacheForFramesInvocations = Invocations<Void>()
     public override func getDebugImagesFromCacheForFrames(frames: [Frame]) -> [DebugMeta] {

SentryTestUtils/TestDebugImageProvider.swift

@@ -10,7 +10,6 @@ framework module Sentry {
         header "PrivatesHeader.h"
         header "SentryAppStartMeasurement.h"
         header "SentryBreadcrumb+Private.h"
-        header "SentryDebugImageProvider+HybridSDKs.h"
         header "SentryDependencyContainer.h"
         header "SentryFormatter.h"
         header "SentryOptionsInternal.h"

Sources/Resources/Sentry.modulemap

@@ -2,8 +2,6 @@
 #import "SentryAppStartMeasurement.h"
 #import "SentryBreadcrumb+Private.h"
 #import "SentryClient.h"
-#import "SentryDebugImageProvider+HybridSDKs.h"
-#import "SentryDebugImageProvider.h"
 #import "SentryHub+Private.h"
 #import "SentryInstallation.h"
 #import "SentryInternalDefines.h"
@@ -50,23 +48,6 @@ + (nullable SentryEnvelope *)envelopeWithData:(NSData *)data
     return [SentrySerializationSwift envelopeWithData:data];
 }
 
-#if !SDK_V9
-+ (NSArray<SentryDebugMeta *> *)getDebugImages
-{
-    // maintains previous behavior for the same method call by also trying to gather crash info
-    return [self getDebugImagesCrashed:YES];
-}
-
-+ (NSArray<SentryDebugMeta *> *)getDebugImagesCrashed:(BOOL)isCrash
-{
-#    pragma clang diagnostic push
-#    pragma clang diagnostic ignored "-Wdeprecated-declarations"
-    return [[SentryDependencyContainer sharedInstance].debugImageProvider
-        getDebugImagesCrashed:isCrash];
-#    pragma clang diagnostic pop
-}
-#endif // !SDK_V9
-
 + (nullable SentryAppStartMeasurement *)appStartMeasurement
 {
     return [SentrySDKInternal getAppStartMeasurement];

Sources/Sentry/PrivateSentrySDKOnly.m

@@ -4,7 +4,6 @@
 
 #    import "SentryClient+Private.h"
 #    import "SentryDateUtils.h"
-#    import "SentryDebugImageProvider+HybridSDKs.h"
 #    import "SentryDependencyContainer.h"
 #    import "SentryDevice.h"
 #    import "SentryEnvelopeItemHeader.h"

Sources/Sentry/Profiling/SentryProfilerSerialization.m

@@ -12,7 +12,6 @@ FOUNDATION_EXPORT const unsigned char SentryVersionString[];
 #    import <Sentry/SentryBreadcrumb.h>
 #    import <Sentry/SentryClient.h>
 #    import <Sentry/SentryCrashExceptionApplication.h>
-#    import <Sentry/SentryDebugImageProvider.h>
 #    import <Sentry/SentryDebugMeta.h>
 #    import <Sentry/SentryDefines.h>
 #    import <Sentry/SentryDsn.h>

Sources/Sentry/Public/Sentry.h

@@ -13,7 +13,6 @@ FOUNDATION_EXPORT const unsigned char SentryVersionString[];
 #    import <SentryWithoutUIKit/SentryBreadcrumb.h>
 #    import <SentryWithoutUIKit/SentryClient.h>
 #    import <SentryWithoutUIKit/SentryCrashExceptionApplication.h>
-#    import <SentryWithoutUIKit/SentryDebugImageProvider.h>
 #    import <SentryWithoutUIKit/SentryDebugMeta.h>
 #    import <SentryWithoutUIKit/SentryDefines.h>
 #    import <SentryWithoutUIKit/SentryDsn.h>

Sources/Sentry/Public/SentryDebugImageProvider.h

@@ -1,6 +1,5 @@
 #import "SentryANRTrackingIntegration.h"
 #import "SentryCrashMachineContext.h"
-#import "SentryDebugImageProvider+HybridSDKs.h"
 #import "SentryDependencyContainer.h"
 #import "SentryEvent.h"
 #import "SentryException.h"