ref: Migrate SentryBinaryImageCache to Swift (#5995)

* ref: Migrate `SentryBinaryImageCache` to Swift

* Fix compile on xrOS

* Move headers to include folder

* Update sdk json

* Use `SentryDependencyContainerSwiftHelper` for the dispatchQueueWrapper

* Update SDK api json

* Revert to use binary image callbacks in C

* Move `SentryBinaryImageCacheCallbacks` to include folder

* Fix duplicate files

* Use `@_spi(Private)` and `final` for

* Refactor `imageByAddress` method to simplify index check and update return value in `SentryBinaryImageCache`

* Fix PR review comments

* Revert to use `self.cache?.insert`

* Revert unmutated variable to use let

Author: itaybre

Sentry.xcodeproj/project.pbxproj

@@ -25,7 +25,6 @@
 
 #import "PrivateSentrySDKOnly.h"
 #import "SentryAppStartMeasurement.h"
-#import "SentryBinaryImageCache.h"
 #import "SentryClient+Private.h"
 #import "SentryClient+TestInit.h"
 #import "SentryCrash+Test.h"

SentryTestUtils/SentryTestUtils-ObjC-BridgingHeader.h

@@ -9,7 +9,6 @@ framework module Sentry {
         header "PrivateSentrySDKOnly.h"
         header "PrivatesHeader.h"
         header "SentryAppStartMeasurement.h"
-        header "SentryBinaryImageCache.h"
         header "SentryBreadcrumb+Private.h"
         header "SentryDebugImageProvider+HybridSDKs.h"
         header "SentryDependencyContainer.h"

Sources/Resources/Sentry.modulemap

@@ -1,5 +1,4 @@
 #import "SentryCrashStackEntryMapper.h"
-#import "SentryBinaryImageCache.h"
 #import "SentryDependencyContainer.h"
 #import "SentryFormatter.h"
 #import "SentryFrame.h"
@@ -42,7 +41,7 @@ - (SentryFrame *)sentryCrashStackEntryToSentryFrame:(SentryCrashStackEntry)stack
     // we get image from the cache.
     if (stackEntry.imageAddress == 0 && stackEntry.imageName == NULL) {
         SentryBinaryImageInfo *info = [SentryDependencyContainer.sharedInstance.binaryImageCache
-            imageByAddress:stackEntry.address];
+            imageByAddress:(uint64_t)stackEntry.address];
 
         frame.imageAddress = sentry_formatHexAddressUInt64(info.address);
         frame.package = info.name;

Sources/Sentry/SentryBinaryImageCache.m

@@ -1,5 +1,4 @@
 #import "SentryDebugImageProvider.h"
-#import "SentryBinaryImageCache.h"
 #import "SentryDebugImageProvider+HybridSDKs.h"
 #if !SDK_V9
 #    import "SentryCrashDefaultBinaryImageProvider.h"
@@ -13,6 +12,7 @@
 #import "SentryInternalDefines.h"
 #import "SentryLogC.h"
 #import "SentryStacktrace.h"
+#import "SentrySwift.h"
 #import "SentryThread.h"
 #import <Foundation/Foundation.h>
 
@@ -228,7 +228,7 @@ - (SentryDebugMeta *)fillDebugMetaFrom:(SentryCrashBinaryImage)image
 - (SentryDebugMeta *)fillDebugMetaFromBinaryImageInfo:(SentryBinaryImageInfo *)info
 {
     SentryDebugMeta *debugMeta = [[SentryDebugMeta alloc] init];
-    debugMeta.debugID = info.UUID;
+    debugMeta.debugID = info.uuid;
     debugMeta.type = SentryDebugImageType;
 
     if (info.vmAddress > 0) {

Sources/Sentry/SentryCrashStackEntryMapper.m

@@ -1,7 +1,6 @@
 #import "SentryANRTrackerV1.h"
 
 #import "SentryApplication.h"
-#import "SentryBinaryImageCache.h"
 #import "SentryDefaultObjCRuntimeWrapper.h"
 #import "SentryDispatchFactory.h"
 #import "SentryDisplayLinkWrapper.h"

Sources/Sentry/SentryDebugImageProvider.m

@@ -3,7 +3,6 @@
 #import "SentryANRTrackingIntegration.h"
 #import "SentryAppStartMeasurement.h"
 #import "SentryAppStateManager.h"
-#import "SentryBinaryImageCache.h"
 #import "SentryBreadcrumb.h"
 #import "SentryClient+Private.h"
 #import "SentryCrash.h"

Sources/Sentry/SentryDependencyContainer.m

@@ -2,7 +2,6 @@
 
 #if SENTRY_HAS_UIKIT
 
-#    import "SentryBinaryImageCache.h"
 #    import "SentryDefaultObjCRuntimeWrapper.h"
 #    import "SentryDefines.h"
 #    import "SentryDependencyContainer.h"