fix(react-router): Ensure source map upload fails if Sentry CLI fails

Author: Lms24

packages/react-router/package.json

@@ -39,7 +39,7 @@
     "@opentelemetry/instrumentation": "^0.203.0",
     "@opentelemetry/semantic-conventions": "^1.34.0",
     "@sentry/browser": "9.40.0",
-    "@sentry/cli": "^2.46.0",
+    "@sentry/cli": "^2.49.0",
     "@sentry/core": "9.40.0",
     "@sentry/node": "9.40.0",
     "@sentry/react": "9.40.0",

packages/react-router/src/vite/buildEnd/handleOnBuildEnd.ts

@@ -59,7 +59,12 @@ export const sentryOnBuildEnd: BuildEndHook = async ({ reactRouterConfig, viteCo
   if (sourceMapsUploadOptions?.enabled ?? (true && viteConfig.build.sourcemap !== false)) {
     // inject debugIds
     try {
-      await cliInstance.execute(['sourcemaps', 'inject', reactRouterConfig.buildDirectory], debug);
+      await cliInstance.execute(
+        ['sourcemaps', 'inject', reactRouterConfig.buildDirectory],
+        // @ts-expect-error - 'rejectOnError' is not yet exported as a type from @sentry/cli. It is valid though.
+        // TODO: update to @sentry/[email protected] once the fix is released: https://github.com/getsentry/sentry-cli/pull/2628
+        debug ? 'rejectOnError' : false,
+      );
     } catch (error) {
       // eslint-disable-next-line no-console
       console.error('[Sentry] Could not inject debug ids', error);
@@ -73,6 +78,7 @@ export const sentryOnBuildEnd: BuildEndHook = async ({ reactRouterConfig, viteCo
             paths: [reactRouterConfig.buildDirectory],
           },
         ],
+        live: 'rejectOnError',
       });
     } catch (error) {
       // eslint-disable-next-line no-console

yarn.lock

@@ -7090,7 +7090,7 @@
     "@sentry/cli-win32-i686" "2.42.2"
     "@sentry/cli-win32-x64" "2.42.2"
 
-"@sentry/cli@^2.36.1", "@sentry/cli@^2.46.0", "@sentry/cli@^2.50.0":
+"@sentry/cli@^2.36.1", "@sentry/cli@^2.50.0":
   version "2.50.0"
   resolved "https://registry.yarnpkg.com/@sentry/cli/-/cli-2.50.0.tgz#7e2298bea9a2bb50126bfb24116ae98199bc1f6f"
   integrity sha512-OHRRQPUNjBpzOT6arNhxXQ71DKs5jSziCfDzmEGwAs+K8J/I1QxnvJkto88HbXE54oiWhSEJwL0pvcowFXyVbA==
@@ -7110,6 +7110,26 @@
     "@sentry/cli-win32-i686" "2.50.0"
     "@sentry/cli-win32-x64" "2.50.0"
 
+"@sentry/cli@^2.49.0":
+  version "2.49.0"
+  resolved "https://registry.yarnpkg.com/@sentry/cli/-/cli-2.49.0.tgz#a8332ae38e9f92a0da3d939bdbce119e63450e99"
+  integrity sha512-99IKax3yjOaPlWJh3rAJC/R6hdmZZJ2B3ACVP8CpOYE+JzGGLyir1fvTzrdFKFLPLOq2lGC3RqWuKqU7PJUTZQ==
+  dependencies:
+    https-proxy-agent "^5.0.0"
+    node-fetch "^2.6.7"
+    progress "^2.0.3"
+    proxy-from-env "^1.1.0"
+    which "^2.0.2"
+  optionalDependencies:
+    "@sentry/cli-darwin" "2.49.0"
+    "@sentry/cli-linux-arm" "2.49.0"
+    "@sentry/cli-linux-arm64" "2.49.0"
+    "@sentry/cli-linux-i686" "2.49.0"
+    "@sentry/cli-linux-x64" "2.49.0"
+    "@sentry/cli-win32-arm64" "2.49.0"
+    "@sentry/cli-win32-i686" "2.49.0"
+    "@sentry/cli-win32-x64" "2.49.0"
+
 "@sentry/rollup-plugin@^3.5.0":
   version "3.5.0"
   resolved "https://registry.yarnpkg.com/@sentry/rollup-plugin/-/rollup-plugin-3.5.0.tgz#9015c48e00257f8440597167498499804371329b"