-
Notifications
You must be signed in to change notification settings - Fork 555
feat(tracing): Improve @trace
decorator.
#4648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4648 +/- ##
==========================================
+ Coverage 85.07% 85.08% +0.01%
==========================================
Files 156 156
Lines 15824 15836 +12
Branches 2677 2677
==========================================
+ Hits 13462 13474 +12
+ Misses 1583 1582 -1
- Partials 779 780 +1
|
@trace
decorator.
Co-authored-by: Daniel Szoke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few small suggestions, can do a more in depth review once they're addressed
Update the
@trace
decorator and make it more powerful. It accepts now the following parameters:op
,name
,attributes
.Example usage:
This creates better DX for our users.