chore: Update desktop integration tests to use app-runner module #1165
+107
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
sample/Source/SentryPlayground/SentryPlaygroundGameInstance.cpp
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sample/Source/SentryPlayground/SentryPlaygroundGameInstance.cpp
Outdated
Show resolved
Hide resolved
limbonaut
approved these changes
Dec 9, 2025
Collaborator
limbonaut
left a comment
limbonaut
left a comment
There was a problem hiding this comment.
Looks good! Have you thought about combining tests to run on all platforms in app-runner?
mujacica
approved these changes
Dec 9, 2025
Collaborator
Author
Given the setup differences required for running tests on each supported platform it’s simpler to keep them separate for now. However, once we get e2e tests working everywhere (iOS, consoles) it does make sense to consider unifying/merging the existing scripts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the existing integration tests for desktop platforms to use the
app-runnermodule for launching the plugin demo, replacing the previous custom implementation.Key changes:
Related to:
#skip-changelog