Skip to content

Commit 27d6540

Browse files
ref(releases): fix issue count on release index & other spots (#99555)
closes https://linear.app/getsentry/issue/REPLAY-706/release-newgroups-count-is-sometimes-incorrect closes https://linear.app/getsentry/issue/REPLAY-151/release-overview-new-issues-counter-doesnt-filter-when-selecting closes https://linear.app/getsentry/issue/REPLAY-139/new-issues-in-release-showing-up-unexpectedly-in-the-team-plan i believe all the issues above were relating to an incorrect issue count value in the release row, leading to confusion about the actual count of new issues for that release. the `newGroups` value returned by the `/releases/` endpoint is correct; however, the frontend on the releases index was mistakenly using the project's `newGroups` field.  The project's `newGroups` field is the sum of all the new issues for that project -- hence why they're all the same in the photo below. we should instead be using the count from the release itself. i also fixed 2 other spots where we were relying on the project `newGroups` field in insights mobile session health page & on release drawer. before: <img width="1084" height="376" alt="SCR-20250915-nxra" src="https://github.com/user-attachments/assets/2f2044b7-4cb2-49e1-b2fb-437589bf0212" /> <img width="1272" height="514" alt="SCR-20250915-oech" src="https://github.com/user-attachments/assets/d6b7d321-c91b-4221-a673-bdc2656c40a5" /> after: <img width="1080" height="346" alt="SCR-20250915-nxnn" src="https://github.com/user-attachments/assets/a72f03fd-e478-4e22-a6c8-217958674cfc" /> <img width="1267" height="564" alt="SCR-20250915-ocyn" src="https://github.com/user-attachments/assets/65364c90-f9de-459a-af16-82ab1313fdd8" />
1 parent 41492da commit 27d6540

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

static/app/views/insights/sessions/queries/useOrganizationReleases.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ export default function useOrganizationReleases({
9797
: '',
9898
crash_free_sessions: release.projects[0]?.healthData?.crashFreeSessions ?? 0,
9999
sessions: release.projects[0]?.healthData?.totalSessions ?? 0,
100-
error_count: release.projects[0]?.newGroups ?? 0,
100+
error_count: release.newGroups ?? 0,
101101
project_id: release.projects[0]?.id ?? 0,
102102
adoption: release.projects[0]?.healthData?.adoption ?? 0,
103103
status: release.status,

static/app/views/releases/drawer/releasesDrawerTable.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export function ReleasesDrawerTable({
9494
project: d.projects[0]!,
9595
release: d.version,
9696
date: d.dateCreated,
97-
error_count: d.projects[0]?.newGroups ?? 0,
97+
error_count: d.newGroups ?? 0,
9898
project_id: d.projects[0]?.id ?? 0,
9999
}));
100100

static/app/views/releases/list/releaseCard/index.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ function ReleaseCard({
8888
dateCreated,
8989
versionInfo,
9090
adoptionStages,
91+
newGroups,
9192
projects,
9293
} = release;
9394

@@ -267,6 +268,7 @@ function ReleaseCard({
267268
location={location}
268269
organization={organization}
269270
project={project}
271+
newGroups={newGroups}
270272
releaseVersion={version}
271273
showPlaceholders={showHealthPlaceholders}
272274
showReleaseAdoptionStages={showReleaseAdoptionStages}

static/app/views/releases/list/releaseCard/releaseCardProjectRow.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ type Props = {
6565
index: number;
6666
isTopRelease: boolean;
6767
location: Location;
68+
newGroups: number;
6869
organization: Organization;
6970
project: ReleaseProject;
7071
releaseVersion: string;
@@ -85,9 +86,10 @@ function ReleaseCardProjectRow({
8586
releaseVersion,
8687
showPlaceholders,
8788
showReleaseAdoptionStages,
89+
newGroups,
8890
}: Props) {
8991
const theme = useTheme();
90-
const {id, newGroups} = project;
92+
const {id} = project;
9193

9294
const crashCount = getHealthData.getCrashCount(
9395
releaseVersion,

0 commit comments

Comments
 (0)