chore(detectors): Update experimental N+1 API detector to use rollout flag (#99556)

adds flag so we can roll out experimental n+1 api call detector.

Author: roggenkemper

src/sentry/performance_issues/detectors/experiments/n_plus_one_api_calls_detector.py

@@ -6,7 +6,8 @@
 from typing import Any
 from urllib.parse import urlparse
 
-from sentry.issues.grouptype import PerformanceNPlusOneAPICallsExperimentalGroupType
+from sentry import features
+from sentry.issues.grouptype import PerformanceNPlusOneAPICallsGroupType
 from sentry.issues.issue_occurrence import IssueEvidence
 from sentry.models.organization import Organization
 from sentry.models.project import Project
@@ -73,7 +74,9 @@ def visit_span(self, span: Span) -> None:
             self.spans = [span]
 
     def is_creation_allowed_for_organization(self, organization: Organization) -> bool:
-        return True
+        return features.has(
+            "organizations:experimental-n-plus-one-api-detector-rollout", organization
+        )
 
     def is_creation_allowed_for_project(self, project: Project) -> bool:
         return self.settings["detection_enabled"]
@@ -177,7 +180,7 @@ def _maybe_store_problem(self) -> None:
             fingerprint=fingerprint,
             op=last_span["op"],
             desc=problem_description,
-            type=PerformanceNPlusOneAPICallsExperimentalGroupType,
+            type=PerformanceNPlusOneAPICallsGroupType,
             cause_span_ids=[],
             parent_span_ids=[parent_span_id] if parent_span_id else [],
             offender_span_ids=offender_span_ids,
@@ -262,7 +265,7 @@ def _fingerprint(self) -> str | None:
 
         fingerprint = fingerprint_http_spans([self.spans[0]])
 
-        return f"1-{PerformanceNPlusOneAPICallsExperimentalGroupType.type_id}-{fingerprint}"
+        return f"1-{PerformanceNPlusOneAPICallsGroupType.type_id}-{fingerprint}"
 
     def _spans_are_concurrent(self, span_a: Span, span_b: Span) -> bool:
         span_a_start = span_a["start_timestamp"]

src/sentry/performance_issues/detectors/n_plus_one_api_calls_detector.py

@@ -10,6 +10,7 @@
 
 from django.utils.encoding import force_bytes
 
+from sentry import features
 from sentry.issues.grouptype import PerformanceNPlusOneAPICallsGroupType
 from sentry.issues.issue_occurrence import IssueEvidence
 from sentry.models.organization import Organization
@@ -73,7 +74,9 @@ def visit_span(self, span: Span) -> None:
             self.spans = [span]
 
     def is_creation_allowed_for_organization(self, organization: Organization) -> bool:
-        return True
+        return not features.has(
+            "organizations:experimental-n-plus-one-api-detector-rollout", organization
+        )
 
     def is_creation_allowed_for_project(self, project: Project) -> bool:
         return self.settings["detection_enabled"]

tests/sentry/performance_issues/experiments/test_n_plus_one_api_calls_detector.py

@@ -6,7 +6,7 @@
 
 import pytest
 
-from sentry.issues.grouptype import PerformanceNPlusOneAPICallsExperimentalGroupType
+from sentry.issues.grouptype import PerformanceNPlusOneAPICallsGroupType
 from sentry.performance_issues.base import DetectorType, parameterize_url
 from sentry.performance_issues.detectors.experiments.n_plus_one_api_calls_detector import (
     NPlusOneAPICallsExperimentalDetector,
@@ -26,7 +26,7 @@
 
 @pytest.mark.django_db
 class NPlusOneAPICallsExperimentalDetectorTest(TestCase):
-    type_id = PerformanceNPlusOneAPICallsExperimentalGroupType.type_id
+    type_id = PerformanceNPlusOneAPICallsGroupType.type_id
 
     def setUp(self) -> None:
         super().setUp()
@@ -79,7 +79,7 @@ def test_detects_problems_with_many_concurrent_calls_to_same_url(self) -> None:
             PerformanceProblem(
                 fingerprint=f"1-{self.type_id}-d750ce46bb1b13dd5780aac48098d5e20eea682c",
                 op="http.client",
-                type=PerformanceNPlusOneAPICallsExperimentalGroupType,
+                type=PerformanceNPlusOneAPICallsGroupType,
                 desc="GET /api/0/organizations/sentry/events/?field=replayId&field=count%28%29&per_page=50&query=issue.id%3A",
                 parent_span_ids=["a0c39078d1570b00"],
                 cause_span_ids=[],
@@ -145,7 +145,7 @@ def test_detects_problems_with_many_concurrent_calls_to_same_url(self) -> None:
                 evidence_display=[],
             )
         ]
-        assert problems[0].title == "N+1 API Call (Experimental)"
+        assert problems[0].title == "N+1 API Call"
 
     def test_does_not_detect_problems_with_low_total_duration_of_spans(self) -> None:
         event = get_event("n-plus-one-api-calls/n-plus-one-api-calls-in-issue-stream")