Skip to content

Commit d251568

Browse files
authored
ref(feedback): simplify categories test coverage to be more efficient (#99451)
1 parent e83b6e8 commit d251568

File tree

5 files changed

+317
-755
lines changed

5 files changed

+317
-755
lines changed

src/sentry/feedback/usecases/ingest/create_feedback.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ def fix_for_issue_platform(event_data: dict[str, Any]) -> dict[str, Any]:
158158
for [k, v] in tags:
159159
tags_dict[k] = v
160160
else:
161-
tags_dict = tags
161+
tags_dict = tags.copy() # Avoid mutating the original event.
162162
ret_event["tags"] = tags_dict
163163

164164
# Set the event message to the feedback message.

tests/sentry/feedback/__init__.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,17 @@
1-
from datetime import UTC, datetime
1+
from datetime import UTC, datetime, timedelta
22
from typing import Any
33

44
from sentry.utils import json
55

66

77
def mock_feedback_event(
8-
project_id: int, dt: datetime | None = None, message: str | None = None
8+
project_id: int,
9+
dt: datetime | None = None,
10+
message: str | None = None,
11+
tags: dict[str, Any] | None = None,
912
) -> dict[str, Any]:
1013
if dt is None:
11-
dt = datetime.now(UTC)
14+
dt = datetime.now(UTC) - timedelta(minutes=5)
1215

1316
return {
1417
"project_id": project_id,
@@ -40,6 +43,7 @@ def mock_feedback_event(
4043
"url": "https://sentry.sentry.io/feedback/?statsPeriod=14d",
4144
},
4245
},
46+
"tags": tags or {},
4347
"breadcrumbs": [],
4448
"platform": "javascript",
4549
}

0 commit comments

Comments
 (0)